Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: mojo/services/tracing/public/cpp/tracing_impl.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/tracing/public/cpp/tracing_impl.h
diff --git a/mojo/services/tracing/public/cpp/tracing_impl.h b/mojo/services/tracing/public/cpp/tracing_impl.h
index 97944e84aae3d2e4a0970aaa7e91664b56c522fd..97db1434edab70f839bccce5a90940d2294ea62e 100644
--- a/mojo/services/tracing/public/cpp/tracing_impl.h
+++ b/mojo/services/tracing/public/cpp/tracing_impl.h
@@ -13,7 +13,7 @@
namespace mojo {
class ApplicationConnection;
-class ApplicationImpl;
+class Shell;
// Connects to mojo:tracing during your Application's Initialize() call once
// per process.
@@ -32,7 +32,7 @@ class TracingImpl : public InterfaceFactory<tracing::TraceProvider> {
// This connects to the tracing service and registers ourselves to provide
// tracing data on demand.
- void Initialize(ApplicationImpl* app);
+ void Initialize(Shell* shell, const std::string& url);
private:
// InterfaceFactory<tracing::TraceProvider> implementation.
« no previous file with comments | « mojo/services/tracing/public/cpp/trace_provider_impl.cc ('k') | mojo/services/tracing/public/cpp/tracing_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698