Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: components/web_view/frame_devtools_agent.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/web_view/frame_devtools_agent.h ('k') | components/web_view/pending_web_view_load.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_view/frame_devtools_agent.cc
diff --git a/components/web_view/frame_devtools_agent.cc b/components/web_view/frame_devtools_agent.cc
index d57ff6b1f59ba18b89d2a9385de57513b0f6a310..e421efb0eb3cf85921a9f4f288ce144da3ffda94 100644
--- a/components/web_view/frame_devtools_agent.cc
+++ b/components/web_view/frame_devtools_agent.cc
@@ -16,7 +16,7 @@
#include "base/values.h"
#include "components/web_view/frame_devtools_agent_delegate.h"
#include "mojo/services/network/public/interfaces/url_loader.mojom.h"
-#include "mojo/shell/public/cpp/application_impl.h"
+#include "mojo/shell/public/cpp/shell.h"
#include "url/gurl.h"
namespace web_view {
@@ -86,13 +86,13 @@ class FrameDevToolsAgent::FrameDevToolsAgentClient
DISALLOW_COPY_AND_ASSIGN(FrameDevToolsAgentClient);
};
-FrameDevToolsAgent::FrameDevToolsAgent(mojo::ApplicationImpl* app,
+FrameDevToolsAgent::FrameDevToolsAgent(mojo::Shell* shell,
FrameDevToolsAgentDelegate* delegate)
- : app_(app),
+ : shell_(shell),
delegate_(delegate),
id_(base::GenerateGUID()),
binding_(this) {
- DCHECK(app_);
+ DCHECK(shell_);
DCHECK(delegate_);
}
@@ -122,7 +122,7 @@ void FrameDevToolsAgent::RegisterAgentIfNecessary() {
return;
DevToolsRegistryPtr devtools_registry;
- app_->ConnectToService("mojo:devtools_service", &devtools_registry);
+ shell_->ConnectToService("mojo:devtools_service", &devtools_registry);
devtools_registry->RegisterAgent(id_, binding_.CreateInterfacePtrAndBind());
}
« no previous file with comments | « components/web_view/frame_devtools_agent.h ('k') | components/web_view/pending_web_view_load.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698