Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: components/html_viewer/html_viewer.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/html_viewer/html_frame_delegate.h ('k') | components/html_viewer/html_viewer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_HTML_VIEWER_HTML_VIEWER_H_ 5 #ifndef COMPONENTS_HTML_VIEWER_HTML_VIEWER_H_
6 #define COMPONENTS_HTML_VIEWER_HTML_VIEWER_H_ 6 #define COMPONENTS_HTML_VIEWER_HTML_VIEWER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "mojo/shell/public/cpp/application_delegate.h" 10 #include "mojo/shell/public/cpp/application_delegate.h"
11 #include "mojo/shell/public/cpp/interface_factory_impl.h" 11 #include "mojo/shell/public/cpp/interface_factory.h"
12 #include "mojo/shell/public/interfaces/content_handler.mojom.h" 12 #include "mojo/shell/public/interfaces/content_handler.mojom.h"
13 13
14 namespace html_viewer { 14 namespace html_viewer {
15 15
16 class GlobalState; 16 class GlobalState;
17 17
18 class HTMLViewer 18 class HTMLViewer
19 : public mojo::ApplicationDelegate, 19 : public mojo::ApplicationDelegate,
20 public mojo::InterfaceFactory<mojo::shell::mojom::ContentHandler> { 20 public mojo::InterfaceFactory<mojo::shell::mojom::ContentHandler> {
21 public: 21 public:
22 HTMLViewer(); 22 HTMLViewer();
23 ~HTMLViewer() override; 23 ~HTMLViewer() override;
24 24
25 protected: 25 protected:
26 GlobalState* global_state() const { return global_state_.get(); } 26 GlobalState* global_state() const { return global_state_.get(); }
27 mojo::ApplicationImpl* app() const { return app_; } 27 mojo::Shell* shell() const { return shell_; }
28 28
29 // Overridden from ApplicationDelegate: 29 // Overridden from ApplicationDelegate:
30 void Initialize(mojo::ApplicationImpl* app) override; 30 void Initialize(mojo::Shell* shell, const std::string& url,
31 uint32_t id) override;
31 32
32 private: 33 private:
33 // Overridden from ApplicationDelegate: 34 // Overridden from ApplicationDelegate:
34 bool AcceptConnection( 35 bool AcceptConnection(
35 mojo::ApplicationConnection* connection) override; 36 mojo::ApplicationConnection* connection) override;
36 37
37 // Overridden from InterfaceFactory<shell::mojom::ContentHandler> 38 // Overridden from InterfaceFactory<shell::mojom::ContentHandler>
38 void Create(mojo::ApplicationConnection* connection, 39 void Create(mojo::ApplicationConnection* connection,
39 mojo::InterfaceRequest<mojo::shell::mojom::ContentHandler> 40 mojo::InterfaceRequest<mojo::shell::mojom::ContentHandler>
40 request) override; 41 request) override;
41 42
42 scoped_ptr<GlobalState> global_state_; 43 scoped_ptr<GlobalState> global_state_;
43 mojo::ApplicationImpl* app_; 44 mojo::Shell* shell_;
44 45
45 DISALLOW_COPY_AND_ASSIGN(HTMLViewer); 46 DISALLOW_COPY_AND_ASSIGN(HTMLViewer);
46 }; 47 };
47 48
48 } // namespace html_viewer 49 } // namespace html_viewer
49 50
50 #endif // COMPONENTS_HTML_VIEWER_HTML_VIEWER_H_ 51 #endif // COMPONENTS_HTML_VIEWER_HTML_VIEWER_H_
OLDNEW
« no previous file with comments | « components/html_viewer/html_frame_delegate.h ('k') | components/html_viewer/html_viewer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698