Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: mandoline/ui/desktop_ui/browser_window.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mandoline/ui/desktop_ui/browser_manager.cc ('k') | mandoline/ui/desktop_ui/browser_window.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MANDOLINE_UI_DESKTOP_UI_BROWSER_WINDOW_H_ 5 #ifndef MANDOLINE_UI_DESKTOP_UI_BROWSER_WINDOW_H_
6 #define MANDOLINE_UI_DESKTOP_UI_BROWSER_WINDOW_H_ 6 #define MANDOLINE_UI_DESKTOP_UI_BROWSER_WINDOW_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 class ProgressView; 44 class ProgressView;
45 class ToolbarView; 45 class ToolbarView;
46 46
47 class BrowserWindow : public mus::WindowTreeDelegate, 47 class BrowserWindow : public mus::WindowTreeDelegate,
48 public web_view::mojom::WebViewClient, 48 public web_view::mojom::WebViewClient,
49 public ViewEmbedder, 49 public ViewEmbedder,
50 public mojo::InterfaceFactory<ViewEmbedder>, 50 public mojo::InterfaceFactory<ViewEmbedder>,
51 public FindBarDelegate, 51 public FindBarDelegate,
52 public mus::WindowManagerDelegate { 52 public mus::WindowManagerDelegate {
53 public: 53 public:
54 BrowserWindow(mojo::ApplicationImpl* app, 54 BrowserWindow(mojo::Shell* shell,
55 mus::mojom::WindowTreeHostFactory* host_factory, 55 mus::mojom::WindowTreeHostFactory* host_factory,
56 BrowserManager* manager); 56 BrowserManager* manager);
57 57
58 void LoadURL(const GURL& url); 58 void LoadURL(const GURL& url);
59 void Close(); 59 void Close();
60 60
61 void ShowOmnibox(); 61 void ShowOmnibox();
62 void ShowFind(); 62 void ShowFind();
63 void GoBack(); 63 void GoBack();
64 void GoForward(); 64 void GoForward();
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 107
108 // Overridden from FindBarDelegate: 108 // Overridden from FindBarDelegate:
109 void OnDoFind(const std::string& find, bool forward) override; 109 void OnDoFind(const std::string& find, bool forward) override;
110 void OnHideFindBar() override; 110 void OnHideFindBar() override;
111 111
112 void Init(mus::Window* root); 112 void Init(mus::Window* root);
113 void EmbedOmnibox(); 113 void EmbedOmnibox();
114 114
115 void Layout(views::View* host); 115 void Layout(views::View* host);
116 116
117 mojo::ApplicationImpl* app_; 117 mojo::Shell* shell_;
118 mus::WindowManagerClient* window_manager_client_; 118 mus::WindowManagerClient* window_manager_client_;
119 scoped_ptr<ui::mojo::UIInit> ui_init_; 119 scoped_ptr<ui::mojo::UIInit> ui_init_;
120 scoped_ptr<views::AuraInit> aura_init_; 120 scoped_ptr<views::AuraInit> aura_init_;
121 mus::mojom::WindowTreeHostPtr host_; 121 mus::mojom::WindowTreeHostPtr host_;
122 BrowserManager* manager_; 122 BrowserManager* manager_;
123 ToolbarView* toolbar_view_; 123 ToolbarView* toolbar_view_;
124 ProgressView* progress_bar_; 124 ProgressView* progress_bar_;
125 FindBarView* find_bar_view_; 125 FindBarView* find_bar_view_;
126 mus::Window* root_; 126 mus::Window* root_;
127 mus::Window* content_; 127 mus::Window* content_;
(...skipping 14 matching lines...) Expand all
142 142
143 OmniboxPtr omnibox_; 143 OmniboxPtr omnibox_;
144 scoped_ptr<mojo::ApplicationConnection> omnibox_connection_; 144 scoped_ptr<mojo::ApplicationConnection> omnibox_connection_;
145 145
146 DISALLOW_COPY_AND_ASSIGN(BrowserWindow); 146 DISALLOW_COPY_AND_ASSIGN(BrowserWindow);
147 }; 147 };
148 148
149 } // namespace mandoline 149 } // namespace mandoline
150 150
151 #endif // MANDOLINE_UI_DESKTOP_UI_BROWSER_WINDOW_H_ 151 #endif // MANDOLINE_UI_DESKTOP_UI_BROWSER_WINDOW_H_
OLDNEW
« no previous file with comments | « mandoline/ui/desktop_ui/browser_manager.cc ('k') | mandoline/ui/desktop_ui/browser_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698