mash/shelf/shelf_tooltip_manager.cc - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mash/shelf/shelf_tooltip_manager.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mash/shelf/shelf_tooltip_manager.cc

diff --git a/mash/shelf/shelf_tooltip_manager.cc b/mash/shelf/shelf_tooltip_manager.cc

index 635b2a58496fb14f7efb1fd321acd4e0aa03c0d2..5b29c20bf04b99ca1d65da7b683d65caac6ad2e4 100644

--- a/mash/shelf/shelf_tooltip_manager.cc

+++ b/mash/shelf/shelf_tooltip_manager.cc

@@ -11,7 +11,6 @@

#include "components/mus/public/cpp/property_type_converters.h"

#include "mash/shelf/shelf_view.h"

#include "mash/wm/public/interfaces/container.mojom.h"

-#include "mojo/shell/public/cpp/application_impl.h"

#include "ui/aura/window.h"

#include "ui/events/event.h"

#include "ui/events/event_constants.h"

@@ -124,7 +123,7 @@ void ShelfTooltipManager::ShelfTooltipBubble::OnBeforeBubbleWidgetInit(

mus::Window* window =

views::WindowManagerConnection::Get()->NewWindow(properties);

params->native_widget = new views::NativeWidgetMus(

- widget, host_->shelf_view()->app()->shell(), window,

+ widget, host_->shelf_view()->shell(), window,

mus::mojom::SurfaceType::DEFAULT);

}

« no previous file with comments | « mash/shelf/shelf_model.cc ('k') | mash/shelf/shelf_view.h » ('j') | no next file with comments »