mojo/shell/public/cpp/BUILD.gn - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/public/cpp/BUILD.gn

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/shell/package_manager/capability_filter_content_handler_unittest.cc ('k') | mojo/shell/public/cpp/application_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/shell/public/cpp/BUILD.gn

diff --git a/mojo/shell/public/cpp/BUILD.gn b/mojo/shell/public/cpp/BUILD.gn

index 55cd7822011deae078cd9adf7f864ad09e66ab65..81da818d89beaa69b0b27e619b46ef551f7e9453 100644

--- a/mojo/shell/public/cpp/BUILD.gn

+++ b/mojo/shell/public/cpp/BUILD.gn

@@ -41,6 +41,7 @@ source_set("sources") {

"lib/service_registry.h",

"service_connector.h",

"service_provider_impl.h",

+ "shell.h",

]

deps = [