components/web_view/test_frame_tree_delegate.cc - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_view/test_frame_tree_delegate.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_view/test_frame_tree_delegate.h ('k') | components/web_view/test_runner/test_runner_application_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_view/test_frame_tree_delegate.cc

diff --git a/components/web_view/test_frame_tree_delegate.cc b/components/web_view/test_frame_tree_delegate.cc

index 90d8fe9cbb423c7a33dafd4924918bb6417c244b..b1f2c15b05ee2da4c47e9ce8efef85216da32cc6 100644

--- a/components/web_view/test_frame_tree_delegate.cc

+++ b/components/web_view/test_frame_tree_delegate.cc

@@ -13,8 +13,8 @@

namespace web_view {

-TestFrameTreeDelegate::TestFrameTreeDelegate(mojo::ApplicationImpl* app)

- : app_(app),

+TestFrameTreeDelegate::TestFrameTreeDelegate(mojo::Shell* shell)

+ : shell_(shell),

waiting_for_create_frame_(false),

waiting_for_destroy_frame_(nullptr),

most_recent_frame_(nullptr),

@@ -76,7 +76,7 @@ void TestFrameTreeDelegate::CanNavigateFrame(

mojo::URLRequestPtr request,

const CanNavigateFrameCallback& callback) {

FrameConnection::CreateConnectionForCanNavigateFrame(

- app_, target, std::move(request), callback);

+ shell_, target, std::move(request), callback);

}

void TestFrameTreeDelegate::DidStartNavigation(Frame* frame) {}