Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Side by Side Diff: mandoline/services/core_services/core_services_application_delegate.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MANDOLINE_SERVICES_CORE_SERVICES_CORE_SERVICES_APPLICATION_DELEGATE_H_ 5 #ifndef MANDOLINE_SERVICES_CORE_SERVICES_CORE_SERVICES_APPLICATION_DELEGATE_H_
6 #define MANDOLINE_SERVICES_CORE_SERVICES_CORE_SERVICES_APPLICATION_DELEGATE_H_ 6 #define MANDOLINE_SERVICES_CORE_SERVICES_CORE_SERVICES_APPLICATION_DELEGATE_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_vector.h" 9 #include "base/memory/scoped_vector.h"
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 15 matching lines...) Expand all
26 public mojo::InterfaceFactory<mojo::shell::mojom::ContentHandler>, 26 public mojo::InterfaceFactory<mojo::shell::mojom::ContentHandler>,
27 public mojo::shell::mojom::ContentHandler { 27 public mojo::shell::mojom::ContentHandler {
28 public: 28 public:
29 CoreServicesApplicationDelegate(); 29 CoreServicesApplicationDelegate();
30 ~CoreServicesApplicationDelegate() override; 30 ~CoreServicesApplicationDelegate() override;
31 31
32 void ApplicationThreadDestroyed(ApplicationThread* thread); 32 void ApplicationThreadDestroyed(ApplicationThread* thread);
33 33
34 private: 34 private:
35 // Overridden from mojo::ApplicationDelegate: 35 // Overridden from mojo::ApplicationDelegate:
36 void Initialize(mojo::ApplicationImpl* app) override; 36 void Initialize(mojo::Shell* shell, const std::string& url,
37 uint32_t id) override;
37 bool AcceptConnection( 38 bool AcceptConnection(
38 mojo::ApplicationConnection* connection) override; 39 mojo::ApplicationConnection* connection) override;
39 void Quit() override; 40 void Quit() override;
40 41
41 // Overridden from mojo::InterfaceFactory<mojo::shell::mojom::ContentHandler>: 42 // Overridden from mojo::InterfaceFactory<mojo::shell::mojom::ContentHandler>:
42 void Create( 43 void Create(
43 mojo::ApplicationConnection* connection, 44 mojo::ApplicationConnection* connection,
44 mojo::InterfaceRequest<mojo::shell::mojom::ContentHandler> 45 mojo::InterfaceRequest<mojo::shell::mojom::ContentHandler>
45 request) override; 46 request) override;
46 47
(...skipping 10 matching lines...) Expand all
57 mojo::TracingImpl tracing_; 58 mojo::TracingImpl tracing_;
58 59
59 base::WeakPtrFactory<CoreServicesApplicationDelegate> weak_factory_; 60 base::WeakPtrFactory<CoreServicesApplicationDelegate> weak_factory_;
60 61
61 DISALLOW_COPY_AND_ASSIGN(CoreServicesApplicationDelegate); 62 DISALLOW_COPY_AND_ASSIGN(CoreServicesApplicationDelegate);
62 }; 63 };
63 64
64 } // namespace core_services 65 } // namespace core_services
65 66
66 #endif // MANDOLINE_SERVICES_CORE_SERVICES_CORE_SERVICES_APPLICATION_DELEGATE_H _ 67 #endif // MANDOLINE_SERVICES_CORE_SERVICES_CORE_SERVICES_APPLICATION_DELEGATE_H _
OLDNEW
« no previous file with comments | « device/devices_app/devices_apptest.cc ('k') | mandoline/services/core_services/core_services_application_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698