Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: mojo/services/test_service/test_request_tracker_application.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SERVICES_TEST_SERVICE_TEST_REQUEST_TRACKER_APPLICATION_H_ 5 #ifndef SERVICES_TEST_SERVICE_TEST_REQUEST_TRACKER_APPLICATION_H_
6 #define SERVICES_TEST_SERVICE_TEST_REQUEST_TRACKER_APPLICATION_H_ 6 #define SERVICES_TEST_SERVICE_TEST_REQUEST_TRACKER_APPLICATION_H_
7 7
8 #include "mojo/public/cpp/system/macros.h" 8 #include "mojo/public/cpp/system/macros.h"
9 #include "mojo/services/test_service/test_request_tracker_impl.h" 9 #include "mojo/services/test_service/test_request_tracker_impl.h"
10 #include "mojo/shell/public/cpp/application_delegate.h" 10 #include "mojo/shell/public/cpp/application_delegate.h"
11 #include "mojo/shell/public/cpp/interface_factory_impl.h" 11 #include "mojo/shell/public/cpp/interface_factory_impl.h"
12 12
13 namespace mojo { 13 namespace mojo {
14 class ApplicationImpl; 14 class ApplicationImpl;
15 namespace test { 15 namespace test {
16 class TestTimeService; 16 class TestTimeService;
17 17
18 // Embeds TestRequestTracker mojo services into an application. 18 // Embeds TestRequestTracker mojo services into an application.
19 class TestRequestTrackerApplication 19 class TestRequestTrackerApplication
20 : public ApplicationDelegate, 20 : public ApplicationDelegate,
21 public InterfaceFactory<TestTimeService>, 21 public InterfaceFactory<TestTimeService>,
22 public InterfaceFactory<TestRequestTracker>, 22 public InterfaceFactory<TestRequestTracker>,
23 public InterfaceFactory<TestTrackedRequestService> { 23 public InterfaceFactory<TestTrackedRequestService> {
24 public: 24 public:
25 TestRequestTrackerApplication(); 25 TestRequestTrackerApplication();
26 ~TestRequestTrackerApplication() override; 26 ~TestRequestTrackerApplication() override;
27 27
28 void Initialize(ApplicationImpl* app) override;
29
30 // ApplicationDelegate methods: 28 // ApplicationDelegate methods:
29 void Initialize(Shell* shell, const std::string& url, uint32_t id) override;
31 bool AcceptConnection(ApplicationConnection* connection) override; 30 bool AcceptConnection(ApplicationConnection* connection) override;
32 31
33 // InterfaceFactory<TestTimeService> methods: 32 // InterfaceFactory<TestTimeService> methods:
34 void Create(ApplicationConnection* connection, 33 void Create(ApplicationConnection* connection,
35 InterfaceRequest<TestTimeService> request) override; 34 InterfaceRequest<TestTimeService> request) override;
36 35
37 // InterfaceFactory<TestRequestTracker> methods: 36 // InterfaceFactory<TestRequestTracker> methods:
38 void Create(ApplicationConnection* connection, 37 void Create(ApplicationConnection* connection,
39 InterfaceRequest<TestRequestTracker> request) override; 38 InterfaceRequest<TestRequestTracker> request) override;
40 39
41 // InterfaceFactory<TestTrackedRequestService> methods: 40 // InterfaceFactory<TestTrackedRequestService> methods:
42 void Create(ApplicationConnection* connection, 41 void Create(ApplicationConnection* connection,
43 InterfaceRequest<TestTrackedRequestService> request) override; 42 InterfaceRequest<TestTrackedRequestService> request) override;
44 43
45 private: 44 private:
46 ApplicationImpl* app_impl_; 45 Shell* shell_;
47 TrackingContext context_; 46 TrackingContext context_;
48 MOJO_DISALLOW_COPY_AND_ASSIGN(TestRequestTrackerApplication); 47 MOJO_DISALLOW_COPY_AND_ASSIGN(TestRequestTrackerApplication);
49 }; 48 };
50 49
51 } // namespace test 50 } // namespace test
52 } // namespace mojo 51 } // namespace mojo
53 52
54 #endif // SERVICES_TEST_SERVICE_TEST_REQUEST_TRACKER_APPLICATION_H_ 53 #endif // SERVICES_TEST_SERVICE_TEST_REQUEST_TRACKER_APPLICATION_H_
OLDNEW
« no previous file with comments | « mojo/services/network/udp_socket_apptest.cc ('k') | mojo/services/test_service/test_request_tracker_application.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698