media/mojo/services/media_apptest.cc - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/media_apptest.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/mojo/services/media_apptest.cc

diff --git a/media/mojo/services/media_apptest.cc b/media/mojo/services/media_apptest.cc

index 65d93640ccc3fc55d7627db0743d51e91bf7b096..27b525d95645bb4caf2bfe62051e1857139d9a41 100644

--- a/media/mojo/services/media_apptest.cc

+++ b/media/mojo/services/media_apptest.cc

@@ -21,7 +21,6 @@

#include "media/mojo/services/media_type_converters.h"

#include "media/mojo/services/mojo_demuxer_stream_impl.h"

#include "mojo/shell/public/cpp/application_connection.h"

-#include "mojo/shell/public/cpp/application_impl.h"

#include "mojo/shell/public/cpp/application_test_base.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -61,7 +60,7 @@ class MediaAppTest : public mojo::test::ApplicationTestBase {

void SetUp() override {

ApplicationTestBase::SetUp();

- connection_ = application_impl()->ConnectToApplication("mojo:media");

+ connection_ = shell()->ConnectToApplication("mojo:media");

connection_->SetRemoteServiceProviderConnectionErrorHandler(

base::Bind(&MediaAppTest::ConnectionClosed, base::Unretained(this)));

« no previous file with comments | « mash/wm/window_manager_impl.cc ('k') | media/mojo/services/mojo_media_application.h » ('j') | no next file with comments »