Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: mash/shell/shell_application_delegate.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mash/shelf/shelf_view.cc ('k') | mash/shell/shell_application_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mash/shell/shell_application_delegate.h
diff --git a/mash/shell/shell_application_delegate.h b/mash/shell/shell_application_delegate.h
index e0673939aaa2def0364ae71f1ad14413eb3262ea..a36a91a7ed6d6f698fa6fcae550b52f8e57af1d7 100644
--- a/mash/shell/shell_application_delegate.h
+++ b/mash/shell/shell_application_delegate.h
@@ -33,7 +33,8 @@ class ShellApplicationDelegate
private:
// mojo::ApplicationDelegate:
- void Initialize(mojo::ApplicationImpl* app) override;
+ void Initialize(mojo::Shell* shell, const std::string& url,
+ uint32_t id) override;
bool AcceptConnection(
mojo::ApplicationConnection* connection) override;
@@ -61,7 +62,7 @@ class ShellApplicationDelegate
void StartRestartableService(const std::string& url,
const base::Closure& restart_callback);
- mojo::ApplicationImpl* app_;
+ mojo::Shell* shell_;
std::map<std::string, scoped_ptr<mojo::ApplicationConnection>> connections_;
bool screen_locked_;
mojo::WeakBindingSet<mash::shell::mojom::Shell> bindings_;
« no previous file with comments | « mash/shelf/shelf_view.cc ('k') | mash/shell/shell_application_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698