Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1675083002: Rename ApplicationDelegate to ShellClient (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dcheng, devtools-reviews_chromium.org, feature-media-reviews_chromium.org, jam, jochen+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, penghuang+watch-mandoline_chromium.org, Peter Beverloo, pfeldman, qsr+mojo_chromium.org, rjkroege, sadrul, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@delegate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ApplicationDelegate to ShellClient. ApplicationConnection -> Connection TBR=rockot@chromium.org BUG= Committed: https://crrev.com/dbcf6eba1c7f0aa1486ae8c2810402a9221d4bd7 Cr-Commit-Position: refs/heads/master@{#374054}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+688 lines, -1001 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/clipboard/clipboard_application_delegate.h View 1 chunk +5 lines, -10 lines 0 comments Download
M components/clipboard/clipboard_application_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/devtools_service/devtools_service_delegate.h View 2 chunks +6 lines, -7 lines 0 comments Download
M components/devtools_service/devtools_service_delegate.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M components/filesystem/file_system_app.h View 3 chunks +5 lines, -6 lines 0 comments Download
M components/filesystem/file_system_app.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M components/filesystem/file_system_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/filesystem/file_system_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/font_service/font_service_app.h View 2 chunks +5 lines, -6 lines 0 comments Download
M components/font_service/font_service_app.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/html_viewer/ax_provider_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_document.h View 2 chunks +7 lines, -7 lines 0 comments Download
M components/html_viewer/html_document.cc View 7 chunks +6 lines, -7 lines 0 comments Download
M components/html_viewer/html_document_application_delegate.h View 1 2 chunks +7 lines, -8 lines 0 comments Download
M components/html_viewer/html_document_application_delegate.cc View 1 2 6 chunks +7 lines, -9 lines 0 comments Download
M components/html_viewer/html_frame_apptest.cc View 14 chunks +19 lines, -24 lines 0 comments Download
M components/html_viewer/html_viewer.h View 3 chunks +6 lines, -6 lines 0 comments Download
M components/html_viewer/html_viewer.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/html_viewer/layout_test_html_viewer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/html_viewer/layout_test_html_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/stats_collection_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/mus_app.h View 4 chunks +9 lines, -11 lines 0 comments Download
M components/mus/mus_app.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.h View 4 chunks +5 lines, -7 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/mus/ws/connection_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/display_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_manager_client_apptest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 1 2 5 chunks +7 lines, -8 lines 0 comments Download
M components/pdf_viewer/pdf_viewer.cc View 1 2 3 8 chunks +13 lines, -17 lines 0 comments Download
M components/resource_provider/resource_provider_app.h View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M components/resource_provider/resource_provider_app.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M components/resource_provider/resource_provider_apptest.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M components/web_view/frame_apptest.cc View 1 2 5 chunks +6 lines, -10 lines 0 comments Download
M components/web_view/frame_connection.h View 1 3 chunks +3 lines, -5 lines 0 comments Download
M components/web_view/frame_connection.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.h View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M components/web_view/web_view_application_delegate.h View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M components/web_view/web_view_application_delegate.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M components/web_view/web_view_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/web_view_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo_shell_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/common/mojo_shell_connection.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/test_mojo_app.h View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M content/public/test/test_mojo_app.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M content/public/utility/content_utility_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/mus/render_widget_window_tree_client_factory.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M content/shell/utility/shell_content_utility_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/devices_app/devices_app.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M device/devices_app/devices_app.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M device/devices_app/main.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M device/devices_app/public/cpp/devices_app_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/devices_app/public/cpp/devices_app_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/services/core_services/application_delegate_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M mandoline/services/core_services/application_delegate_factory_default.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mandoline/services/core_services/application_delegate_factory_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/services/core_services/application_delegate_factory_notandroid.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.h View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M mandoline/services/updater/updater_app.h View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M mandoline/services/updater/updater_app.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_manager.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/omnibox/omnibox_application.h View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_application.cc View 1 5 chunks +5 lines, -6 lines 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.h View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.h View 1 1 chunk +4 lines, -9 lines 0 comments Download
M mash/browser_driver/browser_driver_application_delegate.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M mash/example/views_examples/views_examples_application_delegate.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.h View 1 chunk +3 lines, -5 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 2 chunks +1 line, -6 lines 0 comments Download
M mash/quick_launch/quick_launch.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M mash/screenlock/screenlock.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mash/shelf/shelf_application.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mash/shell/shell_application_delegate.h View 1 2 4 chunks +7 lines, -8 lines 0 comments Download
M mash/shell/shell_application_delegate.cc View 1 4 chunks +4 lines, -5 lines 0 comments Download
M mash/task_viewer/task_viewer_application_delegate.h View 2 chunks +3 lines, -7 lines 0 comments Download
M mash/task_viewer/task_viewer_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wallpaper/wallpaper.cc View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M mash/wm/window_manager_application.h View 1 3 chunks +6 lines, -7 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M media/mojo/services/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/media_apptest.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M media/mojo/services/mojo_media_application.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/mojo_base.gyp View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M mojo/services/network/http_server_apptest.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M mojo/services/network/mojo_persistent_cookie_store.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/network_service_delegate.h View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 1 4 chunks +6 lines, -7 lines 0 comments Download
M mojo/services/network/udp_socket_apptest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/test_service/test_request_tracker_application.h View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M mojo/services/test_service/test_request_tracker_application.cc View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M mojo/services/test_service/test_request_tracker_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/test_service/test_service_application.h View 1 2 1 chunk +7 lines, -8 lines 0 comments Download
M mojo/services/test_service/test_service_application.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M mojo/services/test_service/test_time_service_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/services/tracing/public/cpp/trace_provider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/tracing/public/cpp/tracing_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/tracing/public/cpp/tracing_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/tracing/tracing_app.h View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M mojo/services/tracing/tracing_app.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M mojo/shell/application_manager_apptest.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M mojo/shell/application_manager_apptest_driver.cc View 1 2 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/shell/application_manager_apptest_target.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/application_manager_unittest.cc View 1 2 9 chunks +13 lines, -14 lines 0 comments Download
M mojo/shell/application_package_apptest.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M mojo/shell/capability_filter_test.h View 1 4 chunks +11 lines, -10 lines 0 comments Download
M mojo/shell/capability_filter_test.cc View 1 2 7 chunks +13 lines, -15 lines 0 comments Download
M mojo/shell/fetcher/about_fetcher_unittest.cc View 1 2 5 chunks +7 lines, -8 lines 0 comments Download
M mojo/shell/package_manager/capability_filter_content_handler_unittest.cc View 1 2 5 chunks +7 lines, -8 lines 0 comments Download
M mojo/shell/package_manager/content_handler_unittest.cc View 1 2 4 chunks +7 lines, -8 lines 0 comments Download
M mojo/shell/public/cpp/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
D mojo/shell/public/cpp/application_connection.h View 1 chunk +0 lines, -152 lines 0 comments Download
D mojo/shell/public/cpp/application_delegate.h View 1 chunk +0 lines, -51 lines 0 comments Download
M mojo/shell/public/cpp/application_impl.h View 1 2 4 chunks +7 lines, -10 lines 0 comments Download
M mojo/shell/public/cpp/application_runner.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/public/cpp/application_test_base.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
A + mojo/shell/public/cpp/connection.h View 6 chunks +24 lines, -28 lines 0 comments Download
M mojo/shell/public/cpp/content_handler_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/interface_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/interface_factory_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
D mojo/shell/public/cpp/lib/application_delegate.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_impl.cc View 1 2 7 chunks +14 lines, -14 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_runner.cc View 1 2 2 chunks +9 lines, -9 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_test_base.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/public/cpp/lib/content_handler_factory.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/lib/interface_factory_connector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/lib/service_connector_registry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/lib/service_connector_registry.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/public/cpp/lib/service_provider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/lib/service_registry.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/public/cpp/lib/service_registry.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A mojo/shell/public/cpp/lib/shell_client.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M mojo/shell/public/cpp/service_connector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/shell.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/shell/public/cpp/shell_client.h View 1 2 chunks +16 lines, -13 lines 0 comments Download
M mojo/shell/public/cpp/tests/service_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/runner/child/native_apptest_target.cc View 1 2 4 chunks +6 lines, -7 lines 0 comments Download
M mojo/shell/runner/child/test_native_main.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/runner/child/test_native_main.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/shell_application_delegate.h View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M mojo/shell/shell_application_delegate.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/shell/standalone/android/android_handler.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/standalone/android/android_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/standalone/test/pingable_app.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/shell/static_application_loader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/static_application_loader.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/screen_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675083002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675083002/40001
4 years, 10 months ago (2016-02-07 00:49:45 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/18518) cast_shell_android on ...
4 years, 10 months ago (2016-02-07 00:55:54 UTC) #6
Ben Goodger (Google)
4 years, 10 months ago (2016-02-07 04:01:10 UTC) #8
Ken Rockot(use gerrit already)
wheee rename all the things, lgtm
4 years, 10 months ago (2016-02-07 04:48:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675083002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675083002/40001
4 years, 10 months ago (2016-02-07 04:59:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/46776)
4 years, 10 months ago (2016-02-07 05:35:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675083002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675083002/60001
4 years, 10 months ago (2016-02-07 06:39:28 UTC) #16
commit-bot: I haz the power
Failed to commit the patch.
4 years, 10 months ago (2016-02-07 15:36:41 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1675083002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1675083002/60001
4 years, 10 months ago (2016-02-07 15:42:31 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-07 15:50:13 UTC) #23
commit-bot: I haz the power
4 years, 10 months ago (2016-02-07 15:51:20 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dbcf6eba1c7f0aa1486ae8c2810402a9221d4bd7
Cr-Commit-Position: refs/heads/master@{#374054}

Powered by Google App Engine
This is Rietveld 408576698