Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: mojo/shell/standalone/test/pingable_app.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/standalone/shell_apptest.cc ('k') | sql/mojo/sql_test_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/standalone/test/pingable_app.cc
diff --git a/mojo/shell/standalone/test/pingable_app.cc b/mojo/shell/standalone/test/pingable_app.cc
index bd92bd5a20f4335b856821b94ee4c860f74de180..31613b872682213107e663c1a7dc98d0c2211c6e 100644
--- a/mojo/shell/standalone/test/pingable_app.cc
+++ b/mojo/shell/standalone/test/pingable_app.cc
@@ -7,9 +7,9 @@
#include "mojo/public/cpp/bindings/interface_request.h"
#include "mojo/public/cpp/bindings/strong_binding.h"
#include "mojo/shell/public/cpp/application_delegate.h"
-#include "mojo/shell/public/cpp/application_impl.h"
#include "mojo/shell/public/cpp/application_runner.h"
#include "mojo/shell/public/cpp/interface_factory.h"
+#include "mojo/shell/public/cpp/shell.h"
#include "mojo/shell/standalone/test/pingable.mojom.h"
namespace mojo {
@@ -44,7 +44,9 @@ class PingableApp : public mojo::ApplicationDelegate,
private:
// ApplicationDelegate:
- void Initialize(ApplicationImpl* impl) override { app_url_ = impl->url(); }
+ void Initialize(Shell* shell, const std::string& url, uint32_t id) override {
+ app_url_ = url;
+ }
bool AcceptConnection(mojo::ApplicationConnection* connection) override {
connection->AddService(this);
« no previous file with comments | « mojo/shell/standalone/shell_apptest.cc ('k') | sql/mojo/sql_test_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698