Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: components/html_viewer/html_widget.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/html_viewer/html_viewer.cc ('k') | components/html_viewer/html_widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/html_viewer/html_widget.h
diff --git a/components/html_viewer/html_widget.h b/components/html_viewer/html_widget.h
index f09e76105592a2d82ae47081cb00fd1be787a276..7ef139d547db8a98f5c937b5b2da550e5a5c6620 100644
--- a/components/html_viewer/html_widget.h
+++ b/components/html_viewer/html_widget.h
@@ -14,7 +14,7 @@ class WebFrameWidget;
}
namespace mojo {
-class ApplicationImpl;
+class Shell;
}
namespace mus {
@@ -63,12 +63,12 @@ class HTMLWidgetRootRemote : public HTMLWidget, public blink::WebViewClient {
class HTMLWidgetRootLocal : public HTMLWidget, public blink::WebViewClient {
public:
struct CreateParams {
- CreateParams(mojo::ApplicationImpl* app,
+ CreateParams(mojo::Shell* shell,
GlobalState* global_state,
mus::Window* window);
~CreateParams();
- mojo::ApplicationImpl* app;
+ mojo::Shell* shell;
GlobalState* global_state;
mus::Window* window;
};
@@ -95,7 +95,7 @@ class HTMLWidgetRootLocal : public HTMLWidget, public blink::WebViewClient {
blink::WebWidget* GetWidget() override;
void OnWindowBoundsChanged(mus::Window* window) override;
- mojo::ApplicationImpl* app_;
+ mojo::Shell* shell_;
GlobalState* global_state_;
mus::Window* window_;
blink::WebView* web_view_;
@@ -108,7 +108,7 @@ class HTMLWidgetRootLocal : public HTMLWidget, public blink::WebViewClient {
// Used for frames other than the root that are local.
class HTMLWidgetLocalRoot : public HTMLWidget, public blink::WebWidgetClient {
public:
- HTMLWidgetLocalRoot(mojo::ApplicationImpl* app,
+ HTMLWidgetLocalRoot(mojo::Shell* shell,
GlobalState* global_state,
mus::Window* window,
blink::WebLocalFrame* web_local_frame);
@@ -128,7 +128,7 @@ class HTMLWidgetLocalRoot : public HTMLWidget, public blink::WebWidgetClient {
void didUpdateTextOfFocusedElementByNonUserInput() override;
void showImeIfNeeded() override;
- mojo::ApplicationImpl* app_;
+ mojo::Shell* shell_;
GlobalState* global_state_;
blink::WebFrameWidget* web_frame_widget_;
scoped_ptr<WebLayerTreeViewImpl> web_layer_tree_view_impl_;
« no previous file with comments | « components/html_viewer/html_viewer.cc ('k') | components/html_viewer/html_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698