mandoline/services/updater/updater_app.h - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/services/updater/updater_app.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mandoline/services/core_services/core_services_application_delegate.cc ('k') | mandoline/services/updater/updater_app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mandoline/services/updater/updater_app.h

diff --git a/mandoline/services/updater/updater_app.h b/mandoline/services/updater/updater_app.h

index 8c7ffd3d585b9e2f7bc2dc565b4c8297401530d9..818efb94481d8b87fd94bab0b23aeb837050ee48 100644

--- a/mandoline/services/updater/updater_app.h

+++ b/mandoline/services/updater/updater_app.h

@@ -11,7 +11,7 @@

namespace mojo {

class ApplicationConnection;

-class ApplicationImpl;

+class Shell;

} // namespace mojo

namespace updater {

@@ -24,9 +24,9 @@ class UpdaterApp : public mojo::ApplicationDelegate,

UpdaterApp();

~UpdaterApp() override;

- void Initialize(mojo::ApplicationImpl* app) override;

// mojo::ApplicationDelegate:

+ void Initialize(mojo::Shell* shell, const std::string& url,

+ uint32_t id) override;

bool AcceptConnection(

mojo::ApplicationConnection* connection) override;

@@ -35,7 +35,7 @@ class UpdaterApp : public mojo::ApplicationDelegate,

mojo::InterfaceRequest<Updater> request) override;

private:

- mojo::ApplicationImpl* app_impl_;

+ mojo::Shell* shell_;

DISALLOW_COPY_AND_ASSIGN(UpdaterApp);

};