Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: components/html_viewer/html_document.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/html_viewer/html_document.h ('k') | components/html_viewer/html_document_application_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/html_viewer/html_document.cc
diff --git a/components/html_viewer/html_document.cc b/components/html_viewer/html_document.cc
index e3b067c9e83364ced1fc03978e3d5b085f9bcc03..fca5dd4405e26124e6e9eddd7e289fbea5cfda36 100644
--- a/components/html_viewer/html_document.cc
+++ b/components/html_viewer/html_document.cc
@@ -94,15 +94,14 @@ void HTMLDocument::TransferableState::Move(TransferableState* other) {
other->owns_window_tree_connection = false;
}
-HTMLDocument::HTMLDocument(mojo::ApplicationImpl* html_document_app,
+HTMLDocument::HTMLDocument(mojo::Shell* html_document_shell,
mojo::ApplicationConnection* connection,
mojo::URLResponsePtr response,
GlobalState* global_state,
const DeleteCallback& delete_callback,
HTMLFactory* factory)
- : app_refcount_(html_document_app->app_lifetime_helper()
- ->CreateAppRefCount()),
- html_document_app_(html_document_app),
+ : app_refcount_(html_document_shell->CreateAppRefCount()),
+ html_document_shell_(html_document_shell),
connection_(connection),
global_state_(global_state),
frame_(nullptr),
@@ -231,8 +230,8 @@ void HTMLDocument::OnFrameDidFinishLoad() {
}
}
-mojo::ApplicationImpl* HTMLDocument::GetApp() {
- return html_document_app_;
+mojo::Shell* HTMLDocument::GetShell() {
+ return html_document_shell_;
}
HTMLFactory* HTMLDocument::GetHTMLFactory() {
« no previous file with comments | « components/html_viewer/html_document.h ('k') | components/html_viewer/html_document_application_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698