mojo/services/test_service/test_service_application.h - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/test_service/test_service_application.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/services/test_service/test_request_tracker_application.cc ('k') | mojo/services/test_service/test_service_application.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/test_service/test_service_application.h

diff --git a/mojo/services/test_service/test_service_application.h b/mojo/services/test_service/test_service_application.h

index 0d3395096770990a350a135a79ec0764fdd0eff0..e4a527a59827d15dc376599b2d6e03b8ba733c8b 100644

--- a/mojo/services/test_service/test_service_application.h

+++ b/mojo/services/test_service/test_service_application.h

@@ -23,9 +23,8 @@ class TestServiceApplication : public ApplicationDelegate,

TestServiceApplication();

~TestServiceApplication() override;

- void Initialize(ApplicationImpl* app) override;

// ApplicationDelegate implementation.

+ void Initialize(Shell* shell, const std::string& url, uint32_t id) override;

bool AcceptConnection(ApplicationConnection* connection) override;

// InterfaceFactory<TestService> implementation.

@@ -41,7 +40,7 @@ class TestServiceApplication : public ApplicationDelegate,

private:

int ref_count_;

- ApplicationImpl* app_impl_;

+ Shell* shell_;

MOJO_DISALLOW_COPY_AND_ASSIGN(TestServiceApplication);

};