Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: components/web_view/frame_devtools_agent.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/web_view/frame_connection.cc ('k') | components/web_view/frame_devtools_agent.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_view/frame_devtools_agent.h
diff --git a/components/web_view/frame_devtools_agent.h b/components/web_view/frame_devtools_agent.h
index 13686f056f72badeddb97f83573aa9dded7e0822..5e35856647a5ef6b3a19834c0d0bc6b38af722a3 100644
--- a/components/web_view/frame_devtools_agent.h
+++ b/components/web_view/frame_devtools_agent.h
@@ -21,7 +21,7 @@ class DictionaryValue;
}
namespace mojo {
-class ApplicationImpl;
+class Shell;
}
namespace web_view {
@@ -34,8 +34,7 @@ class FrameDevToolsAgentDelegate;
// "Page.navigate" requests.
class FrameDevToolsAgent : public devtools_service::DevToolsAgent {
public:
- FrameDevToolsAgent(mojo::ApplicationImpl* app,
- FrameDevToolsAgentDelegate* delegate);
+ FrameDevToolsAgent(mojo::Shell* shell, FrameDevToolsAgentDelegate* delegate);
~FrameDevToolsAgent() override;
// Attaches this agent to a new frame. |forward_agent| is the DevToolsAgent
@@ -62,7 +61,7 @@ class FrameDevToolsAgent : public devtools_service::DevToolsAgent {
const mojo::String& state);
void OnForwardClientClosed();
- mojo::ApplicationImpl* const app_;
+ mojo::Shell* const shell_;
FrameDevToolsAgentDelegate* const delegate_;
const std::string id_;
« no previous file with comments | « components/web_view/frame_connection.cc ('k') | components/web_view/frame_devtools_agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698