components/filesystem/public/cpp/prefs/pref_service_factory.h - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/filesystem/public/cpp/prefs/pref_service_factory.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/filesystem/public/cpp/prefs/pref_service_factory.h

diff --git a/components/filesystem/public/cpp/prefs/pref_service_factory.h b/components/filesystem/public/cpp/prefs/pref_service_factory.h

index 23780ff1a2308bbded897a6383ec6ba7a7d36524..bff39083a6d8920ab069336890a17fbb422e40d6 100644

--- a/components/filesystem/public/cpp/prefs/pref_service_factory.h

+++ b/components/filesystem/public/cpp/prefs/pref_service_factory.h

@@ -9,7 +9,7 @@

#include "components/prefs/pref_service.h"

namespace mojo {

-class ApplicationImpl;

+class Shell;

}

class PrefRegistry;

@@ -19,7 +19,7 @@ namespace filesystem {

// This factory method creates a PrefService for the local process based on the

// preference registry passed in. This PrefService will synchronize with a JSON

// file in the mojo:filesystem.

-scoped_ptr<PrefService> CreatePrefService(mojo::ApplicationImpl* application,

+scoped_ptr<PrefService> CreatePrefService(mojo::Shell* shell,

PrefRegistry* registry);

} // namespace filesystem

« no previous file with comments | « components/filesystem/files_test_base.cc ('k') | components/filesystem/public/cpp/prefs/pref_service_factory.cc » ('j') | no next file with comments »