Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: mandoline/ui/desktop_ui/browser_manager.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mandoline/ui/desktop_ui/browser_apptest.cc ('k') | mandoline/ui/desktop_ui/browser_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mandoline/ui/desktop_ui/browser_manager.h
diff --git a/mandoline/ui/desktop_ui/browser_manager.h b/mandoline/ui/desktop_ui/browser_manager.h
index 57ab8de93018e4cf4dc865b55e1eeb1a9e00d6a7..77becead37f802b5431b60947459d7c56c32f812 100644
--- a/mandoline/ui/desktop_ui/browser_manager.h
+++ b/mandoline/ui/desktop_ui/browser_manager.h
@@ -13,8 +13,6 @@
#include "mojo/common/weak_binding_set.h"
#include "mojo/services/tracing/public/cpp/tracing_impl.h"
#include "mojo/shell/public/cpp/application_delegate.h"
-#include "mojo/shell/public/cpp/application_impl.h"
-#include "mojo/shell/public/cpp/connect.h"
#include "url/gurl.h"
namespace mojo {
@@ -46,7 +44,8 @@ class BrowserManager : public mojo::ApplicationDelegate,
void LaunchURL(const mojo::String& url) override;
// Overridden from mojo::ApplicationDelegate:
- void Initialize(mojo::ApplicationImpl* app) override;
+ void Initialize(mojo::Shell* shell, const std::string& url,
+ uint32_t id) override;
bool AcceptConnection(
mojo::ApplicationConnection* connection) override;
@@ -54,7 +53,7 @@ class BrowserManager : public mojo::ApplicationDelegate,
void Create(mojo::ApplicationConnection* connection,
mojo::InterfaceRequest<LaunchHandler> request) override;
- mojo::ApplicationImpl* app_;
+ mojo::Shell* shell_;
mojo::TracingImpl tracing_;
mus::mojom::WindowTreeHostFactoryPtr host_factory_;
mojo::WeakBindingSet<LaunchHandler> launch_handler_bindings_;
« no previous file with comments | « mandoline/ui/desktop_ui/browser_apptest.cc ('k') | mandoline/ui/desktop_ui/browser_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698