Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: mojo/shell/public/cpp/lib/application_test_base.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/public/cpp/lib/application_impl.cc ('k') | mojo/shell/public/cpp/lib/content_handler_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/public/cpp/lib/application_test_base.cc
diff --git a/mojo/shell/public/cpp/lib/application_test_base.cc b/mojo/shell/public/cpp/lib/application_test_base.cc
index 377220ee0604e9ee0b829506bd5d95c0aa2da860..3d6ad90a093554e4687b20ff006c87d204627dd2 100644
--- a/mojo/shell/public/cpp/lib/application_test_base.cc
+++ b/mojo/shell/public/cpp/lib/application_test_base.cc
@@ -116,7 +116,8 @@ MojoResult RunAllTests(MojoHandle application_request_handle) {
TestHelper::TestHelper(ApplicationDelegate* delegate)
: application_impl_(new ApplicationImpl(
delegate == nullptr ? &default_application_delegate_ : delegate,
- std::move(g_application_request))) {
+ std::move(g_application_request))),
+ url_(g_url) {
// Fake application initialization.
shell::mojom::Application* application = application_impl_.get();
application->Initialize(std::move(g_shell), g_url, g_id);
« no previous file with comments | « mojo/shell/public/cpp/lib/application_impl.cc ('k') | mojo/shell/public/cpp/lib/content_handler_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698