Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: components/devtools_service/devtools_service.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/devtools_service/devtools_service.h
diff --git a/components/devtools_service/devtools_service.h b/components/devtools_service/devtools_service.h
index e8e4f84268163e26df7a1828d57ae92f7cf9825e..974e938318e06fec90dfac7899e8139716fc7714 100644
--- a/components/devtools_service/devtools_service.h
+++ b/components/devtools_service/devtools_service.h
@@ -14,7 +14,7 @@
#include "mojo/common/weak_binding_set.h"
namespace mojo {
-class ApplicationImpl;
+class Shell;
}
namespace devtools_service {
@@ -27,13 +27,13 @@ class DevToolsHttpServer;
class DevToolsService : public DevToolsCoordinator {
public:
// Doesn't take ownership of |application|, which must outlive this object.
- explicit DevToolsService(mojo::ApplicationImpl* application);
+ explicit DevToolsService(mojo::Shell* shell);
~DevToolsService() override;
void BindToCoordinatorRequest(
mojo::InterfaceRequest<DevToolsCoordinator> request);
- mojo::ApplicationImpl* application() { return application_; }
+ mojo::Shell* shell() { return shell_; }
DevToolsRegistryImpl* registry() { return &registry_; }
@@ -42,7 +42,7 @@ class DevToolsService : public DevToolsCoordinator {
void Initialize(uint16_t remote_debugging_port) override;
// Not owned by this object.
- mojo::ApplicationImpl* const application_;
+ mojo::Shell* const shell_;
mojo::WeakBindingSet<DevToolsCoordinator> coordinator_bindings_;
« no previous file with comments | « components/devtools_service/devtools_http_server.cc ('k') | components/devtools_service/devtools_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698