Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: mojo/shell/package_manager/capability_filter_content_handler_unittest.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/fetcher/about_fetcher_unittest.cc ('k') | mojo/shell/public/cpp/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/package_manager/capability_filter_content_handler_unittest.cc
diff --git a/mojo/shell/package_manager/capability_filter_content_handler_unittest.cc b/mojo/shell/package_manager/capability_filter_content_handler_unittest.cc
index 2268a7e9bc15ab439ae65bdff977671a11f3cfe3..7e9ace8500a5a08cf468b0735aca0e7c368abb59 100644
--- a/mojo/shell/package_manager/capability_filter_content_handler_unittest.cc
+++ b/mojo/shell/package_manager/capability_filter_content_handler_unittest.cc
@@ -81,14 +81,12 @@ class TestContentHandler : public ApplicationDelegate,
public InterfaceFactory<mojom::ContentHandler>,
public mojom::ContentHandler {
public:
- TestContentHandler() : app_(nullptr) {}
+ TestContentHandler() {}
~TestContentHandler() override {}
private:
// Overridden from ApplicationDelegate:
- void Initialize(ApplicationImpl* app) override {
- app_ = app;
- }
+ void Initialize(Shell* shell, const std::string& url, uint32_t id) override {}
bool AcceptConnection(ApplicationConnection* connection) override {
connection->AddService<mojom::ContentHandler>(this);
return true;
@@ -112,7 +110,6 @@ class TestContentHandler : public ApplicationDelegate,
destruct_callback.Run();
}
- ApplicationImpl* app_;
WeakBindingSet<mojom::ContentHandler> bindings_;
ScopedVector<ApplicationDelegate> embedded_app_delegates_;
ScopedVector<ApplicationImpl> embedded_apps_;
« no previous file with comments | « mojo/shell/fetcher/about_fetcher_unittest.cc ('k') | mojo/shell/public/cpp/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698