Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: mojo/shell/public/cpp/application_delegate.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/public/cpp/BUILD.gn ('k') | mojo/shell/public/cpp/application_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/public/cpp/application_delegate.h
diff --git a/mojo/shell/public/cpp/application_delegate.h b/mojo/shell/public/cpp/application_delegate.h
index 78211eba90cd782fa77b97984a5ca1f7f70f26c8..b0a537f7907200dbc5e0af240b75cae5a41ab6a0 100644
--- a/mojo/shell/public/cpp/application_delegate.h
+++ b/mojo/shell/public/cpp/application_delegate.h
@@ -5,6 +5,7 @@
#ifndef MOJO_SHELL_PUBLIC_CPP_APPLICATION_DELEGATE_H_
#define MOJO_SHELL_PUBLIC_CPP_APPLICATION_DELEGATE_H_
+#include <stdint.h>
#include <string>
#include "mojo/public/cpp/system/macros.h"
@@ -13,6 +14,7 @@ namespace mojo {
class ApplicationConnection;
class ApplicationImpl;
+class Shell;
// An abstract class that the application may subclass to control various
// behaviors of ApplicationImpl.
@@ -22,7 +24,7 @@ class ApplicationDelegate {
virtual ~ApplicationDelegate();
// Called exactly once before any other method.
- virtual void Initialize(ApplicationImpl* app);
+ virtual void Initialize(Shell* app, const std::string& url, uint32_t id);
// Override this method to configure what services a connection supports when
// being connected to from an app.
« no previous file with comments | « mojo/shell/public/cpp/BUILD.gn ('k') | mojo/shell/public/cpp/application_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698