Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: components/web_view/frame_connection.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/web_view/frame_apptest.cc ('k') | components/web_view/frame_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_view/frame_connection.h
diff --git a/components/web_view/frame_connection.h b/components/web_view/frame_connection.h
index c78acfb67e5c7be20aa5ca5916382f849f7d3617..cd29eddd294f0cf798217690d1282996c55df528 100644
--- a/components/web_view/frame_connection.h
+++ b/components/web_view/frame_connection.h
@@ -18,7 +18,7 @@
namespace mojo {
class ApplicationConnection;
-class ApplicationImpl;
+class Shell;
}
namespace web_view {
@@ -37,7 +37,7 @@ class FrameConnection : public FrameUserData {
// FrameTreeDelegate::CanNavigateFrame(). |callback| is run once the
// content handler id for the app is determined.
static void CreateConnectionForCanNavigateFrame(
- mojo::ApplicationImpl* app,
+ mojo::Shell* shell,
Frame* frame,
mojo::URLRequestPtr request,
const FrameTreeDelegate::CanNavigateFrameCallback& callback);
@@ -45,7 +45,7 @@ class FrameConnection : public FrameUserData {
// Initializes the FrameConnection with the specified parameters.
// |on_got_id_callback| is run once the content handler is obtained from
// the connection.
- void Init(mojo::ApplicationImpl* app,
+ void Init(mojo::Shell* shell,
mojo::URLRequestPtr request,
const base::Closure& on_got_id_callback);
« no previous file with comments | « components/web_view/frame_apptest.cc ('k') | components/web_view/frame_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698