Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: mojo/services/test_service/test_service_application.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/services/test_service/test_service_application.h" 5 #include "mojo/services/test_service/test_service_application.h"
6 6
7 #include <assert.h> 7 #include <assert.h>
8 #include <utility> 8 #include <utility>
9 9
10 #include "mojo/public/c/system/main.h" 10 #include "mojo/public/c/system/main.h"
11 #include "mojo/services/test_service/test_service_impl.h" 11 #include "mojo/services/test_service/test_service_impl.h"
12 #include "mojo/services/test_service/test_time_service_impl.h" 12 #include "mojo/services/test_service/test_time_service_impl.h"
13 #include "mojo/shell/public/cpp/application_connection.h" 13 #include "mojo/shell/public/cpp/application_connection.h"
14 #include "mojo/shell/public/cpp/application_runner.h" 14 #include "mojo/shell/public/cpp/application_runner.h"
15 15
16 namespace mojo { 16 namespace mojo {
17 namespace test { 17 namespace test {
18 18
19 TestServiceApplication::TestServiceApplication() 19 TestServiceApplication::TestServiceApplication()
20 : ref_count_(0), app_impl_(nullptr) { 20 : ref_count_(0), shell_(nullptr) {
21 } 21 }
22 22
23 TestServiceApplication::~TestServiceApplication() { 23 TestServiceApplication::~TestServiceApplication() {
24 } 24 }
25 25
26 void TestServiceApplication::Initialize(ApplicationImpl* app) { 26 void TestServiceApplication::Initialize(Shell* shell, const std::string& url,
27 app_impl_ = app; 27 uint32_t id) {
28 shell_ = shell;
28 } 29 }
29 30
30 bool TestServiceApplication::AcceptConnection( 31 bool TestServiceApplication::AcceptConnection(
31 ApplicationConnection* connection) { 32 ApplicationConnection* connection) {
32 connection->AddService<TestService>(this); 33 connection->AddService<TestService>(this);
33 connection->AddService<TestTimeService>(this); 34 connection->AddService<TestTimeService>(this);
34 return true; 35 return true;
35 } 36 }
36 37
37 void TestServiceApplication::Create(ApplicationConnection* connection, 38 void TestServiceApplication::Create(ApplicationConnection* connection,
38 InterfaceRequest<TestService> request) { 39 InterfaceRequest<TestService> request) {
39 new TestServiceImpl(app_impl_, this, std::move(request)); 40 new TestServiceImpl(shell_, this, std::move(request));
40 AddRef(); 41 AddRef();
41 } 42 }
42 43
43 void TestServiceApplication::Create(ApplicationConnection* connection, 44 void TestServiceApplication::Create(ApplicationConnection* connection,
44 InterfaceRequest<TestTimeService> request) { 45 InterfaceRequest<TestTimeService> request) {
45 new TestTimeServiceImpl(app_impl_, std::move(request)); 46 new TestTimeServiceImpl(shell_, std::move(request));
46 } 47 }
47 48
48 void TestServiceApplication::AddRef() { 49 void TestServiceApplication::AddRef() {
49 assert(ref_count_ >= 0); 50 assert(ref_count_ >= 0);
50 ref_count_++; 51 ref_count_++;
51 } 52 }
52 53
53 void TestServiceApplication::ReleaseRef() { 54 void TestServiceApplication::ReleaseRef() {
54 assert(ref_count_ > 0); 55 assert(ref_count_ > 0);
55 ref_count_--; 56 ref_count_--;
56 if (ref_count_ <= 0) 57 if (ref_count_ <= 0)
57 base::MessageLoop::current()->QuitWhenIdle(); 58 base::MessageLoop::current()->QuitWhenIdle();
58 } 59 }
59 60
60 } // namespace test 61 } // namespace test
61 } // namespace mojo 62 } // namespace mojo
62 63
63 MojoResult MojoMain(MojoHandle shell_handle) { 64 MojoResult MojoMain(MojoHandle shell_handle) {
64 mojo::ApplicationRunner runner(new mojo::test::TestServiceApplication); 65 mojo::ApplicationRunner runner(new mojo::test::TestServiceApplication);
65 return runner.Run(shell_handle); 66 return runner.Run(shell_handle);
66 } 67 }
OLDNEW
« no previous file with comments | « mojo/services/test_service/test_service_application.h ('k') | mojo/services/test_service/test_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698