mojo/shell/shell_application_delegate.h - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/shell_application_delegate.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/shell/shell_application_delegate.h

diff --git a/mojo/shell/shell_application_delegate.h b/mojo/shell/shell_application_delegate.h

index 717e104c9d12f0d436253122298f17e5246f60ea..84e384b2bb880e09552a1553df52f07b0dd1b28d 100644

--- a/mojo/shell/shell_application_delegate.h

+++ b/mojo/shell/shell_application_delegate.h

@@ -28,7 +28,7 @@ class ShellApplicationDelegate

private:

// Overridden from ApplicationDelegate:

- void Initialize(ApplicationImpl* app) override;

+ void Initialize(Shell* shell, const std::string& url, uint32_t id) override;

bool AcceptConnection(ApplicationConnection* connection) override;

// Overridden from InterfaceFactory<mojom::ApplicationManager>:

« no previous file with comments | « mojo/shell/runner/child/native_apptest_target.cc ('k') | mojo/shell/shell_application_delegate.cc » ('j') | no next file with comments »