Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: components/html_viewer/layout_test_content_handler_impl.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/html_viewer/layout_test_content_handler_impl.cc
diff --git a/components/html_viewer/layout_test_content_handler_impl.cc b/components/html_viewer/layout_test_content_handler_impl.cc
index 7471253ac6284e48d6bc99d02e5f09b6a3c40aaa..7683e68df3115783ebb3f8708a1c939c5525b0f8 100644
--- a/components/html_viewer/layout_test_content_handler_impl.cc
+++ b/components/html_viewer/layout_test_content_handler_impl.cc
@@ -48,15 +48,15 @@ class TestHTMLFrame : public HTMLFrame {
LayoutTestContentHandlerImpl::LayoutTestContentHandlerImpl(
GlobalState* global_state,
- mojo::ApplicationImpl* app,
+ mojo::Shell* shell,
mojo::InterfaceRequest<mojo::shell::mojom::ContentHandler> request,
test_runner::WebTestInterfaces* test_interfaces,
WebTestDelegateImpl* test_delegate)
- : ContentHandlerImpl(global_state, app, std::move(request)),
+ : ContentHandlerImpl(global_state, shell, std::move(request)),
test_interfaces_(test_interfaces),
test_delegate_(test_delegate),
web_widget_proxy_(nullptr),
- app_refcount_(app->app_lifetime_helper()->CreateAppRefCount()) {}
+ app_refcount_(shell->CreateAppRefCount()) {}
LayoutTestContentHandlerImpl::~LayoutTestContentHandlerImpl() {
}
@@ -72,7 +72,7 @@ void LayoutTestContentHandlerImpl::StartApplication(
HTMLDocumentApplicationDelegate* delegate =
new HTMLDocumentApplicationDelegate(
std::move(request), std::move(response), global_state(),
- app()->app_lifetime_helper()->CreateAppRefCount(), destruct_callback);
+ shell()->CreateAppRefCount(), destruct_callback);
delegate->set_html_factory(this);
}
« no previous file with comments | « components/html_viewer/layout_test_content_handler_impl.h ('k') | components/html_viewer/layout_test_html_viewer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698