Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Side by Side Diff: content/public/common/mojo_shell_connection.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/mojo/mojo_shell_connection_impl.cc ('k') | content/public/test/test_mojo_app.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_COMMON_MOJO_SHELL_CONNECTION_H_ 5 #ifndef CONTENT_PUBLIC_COMMON_MOJO_SHELL_CONNECTION_H_
6 #define CONTENT_PUBLIC_COMMON_MOJO_SHELL_CONNECTION_H_ 6 #define CONTENT_PUBLIC_COMMON_MOJO_SHELL_CONNECTION_H_
7 7
8 #include "content/common/content_export.h" 8 #include "content/common/content_export.h"
9 9
10 namespace mojo { 10 namespace mojo {
11 class ApplicationConnection; 11 class ApplicationConnection;
12 class ApplicationImpl; 12 class Shell;
13 } 13 }
14 14
15 namespace content { 15 namespace content {
16 16
17 // Encapsulates a connection to a spawning external Mojo shell. 17 // Encapsulates a connection to a spawning external Mojo shell.
18 // Access an instance by calling Get(), on the thread the Shell connection is 18 // Access an instance by calling Get(), on the thread the Shell connection is
19 // bound. Clients can implement Listener, which allows them to register services 19 // bound. Clients can implement Listener, which allows them to register services
20 // to expose to inbound connections. Clients should call this any time after 20 // to expose to inbound connections. Clients should call this any time after
21 // the main message loop is created but not yet run (e.g. in the browser process 21 // the main message loop is created but not yet run (e.g. in the browser process
22 // this object is created in PreMainMessageLoopRun(), so the BrowserMainParts 22 // this object is created in PreMainMessageLoopRun(), so the BrowserMainParts
(...skipping 11 matching lines...) Expand all
34 34
35 // Will return null if no connection has been established (either because it 35 // Will return null if no connection has been established (either because it
36 // hasn't happened yet or the application was not spawned from the external 36 // hasn't happened yet or the application was not spawned from the external
37 // Mojo shell. 37 // Mojo shell.
38 static MojoShellConnection* Get(); 38 static MojoShellConnection* Get();
39 39
40 // Destroys the connection. Must be called on the thread the connection was 40 // Destroys the connection. Must be called on the thread the connection was
41 // created on. 41 // created on.
42 static void Destroy(); 42 static void Destroy();
43 43
44 // Returns an Initialized() ApplicationImpl. 44 // Returns an Initialized() Shell.
45 virtual mojo::ApplicationImpl* GetApplication() = 0; 45 virtual mojo::Shell* GetShell() = 0;
46 46
47 // [De]Register an impl of Listener that will be consulted when the wrapped 47 // [De]Register an impl of Listener that will be consulted when the wrapped
48 // ApplicationImpl exposes services to inbound connections. 48 // ApplicationImpl exposes services to inbound connections.
49 // Registered listeners are owned by this MojoShellConnection. 49 // Registered listeners are owned by this MojoShellConnection.
50 virtual void AddListener(Listener* listener) = 0; 50 virtual void AddListener(Listener* listener) = 0;
51 virtual void RemoveListener(Listener* listener) = 0; 51 virtual void RemoveListener(Listener* listener) = 0;
52 52
53 protected: 53 protected:
54 virtual ~MojoShellConnection(); 54 virtual ~MojoShellConnection();
55 }; 55 };
56 56
57 } // namespace content 57 } // namespace content
58 58
59 #endif // CONTENT_PUBLIC_COMMON_MOJO_SHELL_CONNECTION_H_ 59 #endif // CONTENT_PUBLIC_COMMON_MOJO_SHELL_CONNECTION_H_
OLDNEW
« no previous file with comments | « content/common/mojo/mojo_shell_connection_impl.cc ('k') | content/public/test/test_mojo_app.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698