Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: components/web_view/public/cpp/web_view.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/web_view/public/cpp/web_view.h ('k') | components/web_view/test_frame_tree_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/web_view/public/cpp/web_view.cc
diff --git a/components/web_view/public/cpp/web_view.cc b/components/web_view/public/cpp/web_view.cc
index 647096083e1b4353e39875e9ecb41bf7c7db89d3..e7583380b70e77201c05b10ff622f21776ef748f 100644
--- a/components/web_view/public/cpp/web_view.cc
+++ b/components/web_view/public/cpp/web_view.cc
@@ -9,7 +9,7 @@
#include "base/bind.h"
#include "components/mus/public/cpp/window.h"
-#include "mojo/shell/public/cpp/application_impl.h"
+#include "mojo/shell/public/cpp/shell.h"
namespace web_view {
namespace {
@@ -23,9 +23,9 @@ void OnEmbed(bool success, uint16_t connection_id) {
WebView::WebView(mojom::WebViewClient* client) : binding_(client) {}
WebView::~WebView() {}
-void WebView::Init(mojo::ApplicationImpl* app, mus::Window* window) {
+void WebView::Init(mojo::Shell* shell, mus::Window* window) {
mojom::WebViewFactoryPtr factory;
- app->ConnectToService("mojo:web_view", &factory);
+ shell->ConnectToService("mojo:web_view", &factory);
factory->CreateWebView(binding_.CreateInterfacePtrAndBind(),
GetProxy(&web_view_));
« no previous file with comments | « components/web_view/public/cpp/web_view.h ('k') | components/web_view/test_frame_tree_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698