content/common/mojo/mojo_shell_connection_impl.h - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/mojo/mojo_shell_connection_impl.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mus.cc ('k') | content/common/mojo/mojo_shell_connection_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/mojo/mojo_shell_connection_impl.h

diff --git a/content/common/mojo/mojo_shell_connection_impl.h b/content/common/mojo/mojo_shell_connection_impl.h

index 60331e5807e10a75a94441e6bafd6537b27ee51b..24381385431aa127d2219155144b57f18fb8ea09 100644

--- a/content/common/mojo/mojo_shell_connection_impl.h

+++ b/content/common/mojo/mojo_shell_connection_impl.h

@@ -50,12 +50,13 @@ class MojoShellConnectionImpl : public MojoShellConnection,

~MojoShellConnectionImpl() override;

// mojo::ApplicationDelegate:

- void Initialize(mojo::ApplicationImpl* application) override;

+ void Initialize(mojo::Shell* shell, const std::string& url,

+ uint32_t id) override;

bool AcceptConnection(

mojo::ApplicationConnection* connection) override;

// MojoShellConnection:

- mojo::ApplicationImpl* GetApplication() override;

+ mojo::Shell* GetShell() override;

void AddListener(Listener* listener) override;

void RemoveListener(Listener* listener) override;

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mus.cc ('k') | content/common/mojo/mojo_shell_connection_impl.cc » ('j') | no next file with comments »