components/web_view/public/cpp/web_view.h - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_view/public/cpp/web_view.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/web_view/public/cpp/web_view.h

diff --git a/components/web_view/public/cpp/web_view.h b/components/web_view/public/cpp/web_view.h

index bf5675a083dd2f601f8722664e359449b0afb6dd..72e14de549432a67dec11f8ed86a022a1812b11a 100644

--- a/components/web_view/public/cpp/web_view.h

+++ b/components/web_view/public/cpp/web_view.h

@@ -11,7 +11,7 @@

#include "mojo/public/cpp/bindings/binding.h"

namespace mojo {

-class ApplicationImpl;

+class Shell;

}

namespace mus {

@@ -25,7 +25,7 @@ class WebView {

explicit WebView(mojom::WebViewClient* client);

~WebView();

- void Init(mojo::ApplicationImpl* app, mus::Window* window);

+ void Init(mojo::Shell* shell, mus::Window* window);

mojom::WebView* web_view() { return web_view_.get(); }

« no previous file with comments | « components/web_view/pending_web_view_load.cc ('k') | components/web_view/public/cpp/web_view.cc » ('j') | no next file with comments »