components/html_viewer/web_graphics_context_3d_command_buffer_impl.h - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/web_graphics_context_3d_command_buffer_impl.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/html_viewer/stats_collection_controller.cc ('k') | components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/html_viewer/web_graphics_context_3d_command_buffer_impl.h

diff --git a/components/html_viewer/web_graphics_context_3d_command_buffer_impl.h b/components/html_viewer/web_graphics_context_3d_command_buffer_impl.h

index adcd03dbfa8fc39e5a6757374a4ac4977031b52a..d6a122adf99d6002a5996574ee30f1de724358f6 100644

--- a/components/html_viewer/web_graphics_context_3d_command_buffer_impl.h

+++ b/components/html_viewer/web_graphics_context_3d_command_buffer_impl.h

@@ -15,7 +15,7 @@

#include "url/gurl.h"

namespace mojo {

-class ApplicationImpl;

+class Shell;

}

namespace gpu {

@@ -32,7 +32,7 @@ class WebGraphicsContext3DCommandBufferImpl

public:

static WebGraphicsContext3DCommandBufferImpl* CreateOffscreenContext(

GlobalState* global_state,

- mojo::ApplicationImpl* app,

+ mojo::Shell* shell,

const GURL& active_url,

const blink::WebGraphicsContext3D::Attributes& attributes,

blink::WebGraphicsContext3D* share_context,