Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: mandoline/services/updater/updater_app.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mandoline/services/updater/updater_app.h ('k') | mandoline/services/updater/updater_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mandoline/services/updater/updater_app.cc
diff --git a/mandoline/services/updater/updater_app.cc b/mandoline/services/updater/updater_app.cc
index a9b1cd19a90aac6fda201675f6fdc8a08aa1e3dc..e94dff4feeca6533693d0e02a749997f67496839 100644
--- a/mandoline/services/updater/updater_app.cc
+++ b/mandoline/services/updater/updater_app.cc
@@ -10,19 +10,20 @@
#include "mandoline/services/updater/updater_impl.h"
#include "mojo/public/c/system/main.h"
#include "mojo/shell/public/cpp/application_connection.h"
-#include "mojo/shell/public/cpp/application_impl.h"
#include "mojo/shell/public/cpp/application_runner.h"
+#include "mojo/shell/public/cpp/shell.h"
namespace updater {
-UpdaterApp::UpdaterApp() : app_impl_(nullptr) {
+UpdaterApp::UpdaterApp() : shell_(nullptr) {
}
UpdaterApp::~UpdaterApp() {
}
-void UpdaterApp::Initialize(mojo::ApplicationImpl* app) {
- app_impl_ = app;
+void UpdaterApp::Initialize(mojo::Shell* shell, const std::string& url,
+ uint32_t id) {
+ shell_ = shell;
}
bool UpdaterApp::AcceptConnection(
@@ -33,7 +34,7 @@ bool UpdaterApp::AcceptConnection(
void UpdaterApp::Create(mojo::ApplicationConnection* connection,
mojo::InterfaceRequest<Updater> request) {
- new UpdaterImpl(app_impl_, this, std::move(request));
+ new UpdaterImpl(this, std::move(request));
}
} // namespace updater
« no previous file with comments | « mandoline/services/updater/updater_app.h ('k') | mandoline/services/updater/updater_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698