components/filesystem/public/cpp/prefs/pref_service_factory.cc - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/filesystem/public/cpp/prefs/pref_service_factory.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/filesystem/public/cpp/prefs/pref_service_factory.cc

diff --git a/components/filesystem/public/cpp/prefs/pref_service_factory.cc b/components/filesystem/public/cpp/prefs/pref_service_factory.cc

index 8608b6e8d96bdb9606a44c822741d151ba6d90a6..0fbd0d773affc412710aae887741a93ed575e78c 100644

--- a/components/filesystem/public/cpp/prefs/pref_service_factory.cc

+++ b/components/filesystem/public/cpp/prefs/pref_service_factory.cc

@@ -12,7 +12,7 @@

#include "components/prefs/pref_value_store.h"

#include "components/prefs/value_map_pref_store.h"

#include "components/prefs/writeable_pref_store.h"

-#include "mojo/shell/public/cpp/application_impl.h"

+#include "mojo/shell/public/cpp/shell.h"

namespace filesystem {

@@ -23,10 +23,10 @@ void DoNothingHandleReadError(PersistentPrefStore::PrefReadError error) {}

} // namespace

-scoped_ptr<PrefService> CreatePrefService(mojo::ApplicationImpl* application,

+scoped_ptr<PrefService> CreatePrefService(mojo::Shell* shell,

PrefRegistry* pref_registry) {

filesystem::FileSystemPtr filesystem;

- application->ConnectToService("mojo:filesystem", &filesystem);

+ shell->ConnectToService("mojo:filesystem", &filesystem);

scoped_refptr<FilesystemJsonPrefStore> user_prefs =

new FilesystemJsonPrefStore("preferences.json", std::move(filesystem),

« no previous file with comments | « components/filesystem/public/cpp/prefs/pref_service_factory.h ('k') | components/font_service/font_service_app.h » ('j') | no next file with comments »