Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Side by Side Diff: chrome/browser/ui/views/frame/browser_frame_mus.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/bitmap_uploader/bitmap_uploader.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/frame/browser_frame_mus.h" 5 #include "chrome/browser/ui/views/frame/browser_frame_mus.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "chrome/browser/ui/views/frame/browser_frame.h" 9 #include "chrome/browser/ui/views/frame/browser_frame.h"
10 #include "chrome/browser/ui/views/frame/browser_view.h" 10 #include "chrome/browser/ui/views/frame/browser_view.h"
11 #include "components/mus/public/cpp/window.h" 11 #include "components/mus/public/cpp/window.h"
12 #include "components/mus/public/interfaces/window_tree.mojom.h" 12 #include "components/mus/public/interfaces/window_tree.mojom.h"
13 #include "mojo/shell/public/cpp/application_impl.h"
14 #include "ui/views/mus/window_manager_connection.h" 13 #include "ui/views/mus/window_manager_connection.h"
15 #include "ui/views/mus/window_manager_frame_values.h" 14 #include "ui/views/mus/window_manager_frame_values.h"
16 15
17 namespace { 16 namespace {
18 17
19 views::Widget::InitParams GetWidgetParamsImpl(BrowserView* browser_view) { 18 views::Widget::InitParams GetWidgetParamsImpl(BrowserView* browser_view) {
20 views::Widget::InitParams params; 19 views::Widget::InitParams params;
21 params.bounds = gfx::Rect(10, 10, 640, 480); 20 params.bounds = gfx::Rect(10, 10, 640, 480);
22 params.delegate = browser_view; 21 params.delegate = browser_view;
23 return params; 22 return params;
24 } 23 }
25 24
26 mus::Window* CreateMusWindow(BrowserView* browser_view) { 25 mus::Window* CreateMusWindow(BrowserView* browser_view) {
27 std::map<std::string, std::vector<uint8_t>> properties; 26 std::map<std::string, std::vector<uint8_t>> properties;
28 views::NativeWidgetMus::ConfigurePropertiesForNewWindow( 27 views::NativeWidgetMus::ConfigurePropertiesForNewWindow(
29 GetWidgetParamsImpl(browser_view), &properties); 28 GetWidgetParamsImpl(browser_view), &properties);
30 return views::WindowManagerConnection::Get()->NewWindow(properties); 29 return views::WindowManagerConnection::Get()->NewWindow(properties);
31 } 30 }
32 31
33 } // namespace 32 } // namespace
34 33
35 BrowserFrameMus::BrowserFrameMus(BrowserFrame* browser_frame, 34 BrowserFrameMus::BrowserFrameMus(BrowserFrame* browser_frame,
36 BrowserView* browser_view) 35 BrowserView* browser_view)
37 : views::NativeWidgetMus( 36 : views::NativeWidgetMus(
38 browser_frame, 37 browser_frame,
39 views::WindowManagerConnection::Get()->app()->shell(), 38 views::WindowManagerConnection::Get()->shell(),
40 CreateMusWindow(browser_view), 39 CreateMusWindow(browser_view),
41 mus::mojom::SurfaceType::DEFAULT), 40 mus::mojom::SurfaceType::DEFAULT),
42 browser_view_(browser_view) {} 41 browser_view_(browser_view) {}
43 42
44 BrowserFrameMus::~BrowserFrameMus() {} 43 BrowserFrameMus::~BrowserFrameMus() {}
45 44
46 views::Widget::InitParams BrowserFrameMus::GetWidgetParams() { 45 views::Widget::InitParams BrowserFrameMus::GetWidgetParams() {
47 views::Widget::InitParams params(GetWidgetParamsImpl(browser_view_)); 46 views::Widget::InitParams params(GetWidgetParamsImpl(browser_view_));
48 params.native_widget = this; 47 params.native_widget = this;
49 return params; 48 return params;
(...skipping 18 matching lines...) Expand all
68 } 67 }
69 68
70 int BrowserFrameMus::GetMinimizeButtonOffset() const { 69 int BrowserFrameMus::GetMinimizeButtonOffset() const {
71 return 0; 70 return 0;
72 } 71 }
73 72
74 void BrowserFrameMus::UpdateClientArea() { 73 void BrowserFrameMus::UpdateClientArea() {
75 // BrowserNonClientFrameViewMus::OnBoundsChanged() takes care of updating 74 // BrowserNonClientFrameViewMus::OnBoundsChanged() takes care of updating
76 // the insets. 75 // the insets.
77 } 76 }
OLDNEW
« no previous file with comments | « no previous file | components/bitmap_uploader/bitmap_uploader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698