mojo/services/tracing/main.cc - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/tracing/main.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/services/test_service/test_time_service_impl.cc ('k') | mojo/services/tracing/public/cpp/trace_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/tracing/main.cc

diff --git a/mojo/services/tracing/main.cc b/mojo/services/tracing/main.cc

index c338c97cc2a8beee51836f389ea865fb72f7dad2..b3d7e2742f36408b24e42d02e79642f4a8c46df2 100644

--- a/mojo/services/tracing/main.cc

+++ b/mojo/services/tracing/main.cc

@@ -4,7 +4,6 @@

#include "mojo/public/c/system/main.h"

#include "mojo/services/tracing/tracing_app.h"

-#include "mojo/shell/public/cpp/application_impl.h"

#include "mojo/shell/public/cpp/application_runner.h"

MojoResult MojoMain(MojoHandle shell_handle) {

« no previous file with comments | « mojo/services/test_service/test_time_service_impl.cc ('k') | mojo/services/tracing/public/cpp/trace_provider_impl.cc » ('j') | no next file with comments »