Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: media/mojo/services/mojo_media_application.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/media_apptest.cc ('k') | media/mojo/services/mojo_media_application.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_media_application.h
diff --git a/media/mojo/services/mojo_media_application.h b/media/mojo/services/mojo_media_application.h
index 03ef1c9017fcaab30f54487bd054b0adc834db15..c3ee1b7a04e17ae3de50294f66da22d39391468a 100644
--- a/media/mojo/services/mojo_media_application.h
+++ b/media/mojo/services/mojo_media_application.h
@@ -24,7 +24,9 @@ class MojoMediaApplication
private:
// mojo::ApplicationDelegate implementation.
- void Initialize(mojo::ApplicationImpl* app) final;
+ void Initialize(mojo::Shell* shell,
+ const std::string& url,
+ uint32_t id) final;
bool AcceptConnection(mojo::ApplicationConnection* connection) final;
// mojo::InterfaceFactory<interfaces::ServiceFactory> implementation.
@@ -32,7 +34,7 @@ class MojoMediaApplication
mojo::InterfaceRequest<interfaces::ServiceFactory> request) final;
scoped_ptr<MojoMediaClient> mojo_media_client_;
- mojo::ApplicationImpl* app_impl_;
+ mojo::Shell* shell_;
scoped_refptr<MediaLog> media_log_;
};
« no previous file with comments | « media/mojo/services/media_apptest.cc ('k') | media/mojo/services/mojo_media_application.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698