Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: components/devtools_service/devtools_service_delegate.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/devtools_service/devtools_service_delegate.h ('k') | components/filesystem/file_system_app.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/devtools_service/devtools_service_delegate.cc
diff --git a/components/devtools_service/devtools_service_delegate.cc b/components/devtools_service/devtools_service_delegate.cc
index 3989eb7c1635d7a8ee331744aba59be6f6a4a700..5382703394382a526db3ac52d209090d82085afb 100644
--- a/components/devtools_service/devtools_service_delegate.cc
+++ b/components/devtools_service/devtools_service_delegate.cc
@@ -11,7 +11,7 @@
#include "components/devtools_service/devtools_service.h"
#include "mojo/common/url_type_converters.h"
#include "mojo/shell/public/cpp/application_connection.h"
-#include "mojo/shell/public/cpp/application_impl.h"
+#include "mojo/shell/public/cpp/shell.h"
#include "url/gurl.h"
namespace devtools_service {
@@ -32,8 +32,10 @@ DevToolsServiceDelegate::DevToolsServiceDelegate() {
DevToolsServiceDelegate::~DevToolsServiceDelegate() {
}
-void DevToolsServiceDelegate::Initialize(mojo::ApplicationImpl* app) {
- service_.reset(new DevToolsService(app));
+void DevToolsServiceDelegate::Initialize(mojo::Shell* shell,
+ const std::string& url,
+ uint32_t id) {
+ service_.reset(new DevToolsService(shell));
}
bool DevToolsServiceDelegate::AcceptConnection(
« no previous file with comments | « components/devtools_service/devtools_service_delegate.h ('k') | components/filesystem/file_system_app.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698