components/resource_provider/public/cpp/resource_loader.h - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/resource_provider/public/cpp/resource_loader.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/resource_provider/public/cpp/resource_loader.h

diff --git a/components/resource_provider/public/cpp/resource_loader.h b/components/resource_provider/public/cpp/resource_loader.h

index 5f17652fb18c670ee09fe169ba7c8305e2d67cba..e355d6e593efe605622333f2b42b53888ebca124 100644

--- a/components/resource_provider/public/cpp/resource_loader.h

+++ b/components/resource_provider/public/cpp/resource_loader.h

@@ -22,7 +22,7 @@ class File;

}

namespace mojo {

-class ApplicationImpl;

+class Shell;

}

namespace resource_provider {

@@ -33,8 +33,7 @@ namespace resource_provider {

// have been obtained.

class ResourceLoader {

public:

- ResourceLoader(mojo::ApplicationImpl* app,

- const std::set<std::string>& paths);

+ ResourceLoader(mojo::Shell* shell, const std::set<std::string>& paths);

~ResourceLoader();

// Uses WaitForIncomingMessage() to block until the results are available, or

« no previous file with comments | « components/pdf_viewer/pdf_viewer.cc ('k') | components/resource_provider/public/cpp/resource_loader.cc » ('j') | no next file with comments »