components/resource_provider/resource_provider_apptest.cc - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/resource_provider/resource_provider_apptest.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/resource_provider/resource_provider_apptest.cc

diff --git a/components/resource_provider/resource_provider_apptest.cc b/components/resource_provider/resource_provider_apptest.cc

index 86b7577b203e567ee79bc13fac87ca8a89eb816e..83e77e39adf90dde99a7d63f067f2a4fb5e629ac 100644

--- a/components/resource_provider/resource_provider_apptest.cc

+++ b/components/resource_provider/resource_provider_apptest.cc

@@ -16,7 +16,6 @@

#include "mojo/public/cpp/bindings/array.h"

#include "mojo/public/cpp/system/macros.h"

#include "mojo/shell/public/cpp/application_delegate.h"

-#include "mojo/shell/public/cpp/application_impl.h"

#include "mojo/shell/public/cpp/application_test_base.h"

#include "mojo/shell/public/cpp/service_provider_impl.h"

@@ -58,7 +57,7 @@ class ResourceProviderApplicationTest : public mojo::test::ApplicationTestBase {

// resources are returned. The return map maps from the path to the contents

// of the file at the specified path.

ResourceContentsMap GetResources(const std::set<std::string>& paths) {

- ResourceLoader loader(application_impl(), paths);

+ ResourceLoader loader(shell(), paths);

loader.BlockUntilLoaded();

// Load the contents of each of the handles.

« no previous file with comments | « components/resource_provider/resource_provider_app.cc ('k') | components/web_view/frame_apptest.cc » ('j') | no next file with comments »