Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: content/common/mojo/mojo_shell_connection_impl.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/mojo/mojo_shell_connection_impl.h ('k') | content/public/common/mojo_shell_connection.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/mojo/mojo_shell_connection_impl.cc
diff --git a/content/common/mojo/mojo_shell_connection_impl.cc b/content/common/mojo/mojo_shell_connection_impl.cc
index e614332378c65a35de19d0462efa1cd366f5bda6..95b966875f4c9f16041458103756587b36faa00a 100644
--- a/content/common/mojo/mojo_shell_connection_impl.cc
+++ b/content/common/mojo/mojo_shell_connection_impl.cc
@@ -72,7 +72,9 @@ void MojoShellConnectionImpl::WaitForShell(
application_impl_->WaitForInitialize();
}
-void MojoShellConnectionImpl::Initialize(mojo::ApplicationImpl* application) {
+void MojoShellConnectionImpl::Initialize(mojo::Shell* shell,
+ const std::string& url,
+ uint32_t id) {
initialized_ = true;
}
@@ -84,7 +86,7 @@ bool MojoShellConnectionImpl::AcceptConnection(
return found;
}
-mojo::ApplicationImpl* MojoShellConnectionImpl::GetApplication() {
+mojo::Shell* MojoShellConnectionImpl::GetShell() {
DCHECK(initialized_);
return application_impl_.get();
}
« no previous file with comments | « content/common/mojo/mojo_shell_connection_impl.h ('k') | content/public/common/mojo_shell_connection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698