Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: ui/views/mus/aura_init.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/mus/aura_init.h ('k') | ui/views/mus/native_widget_mus.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/mus/aura_init.h" 5 #include "ui/views/mus/aura_init.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "base/path_service.h" 11 #include "base/path_service.h"
12 #include "build/build_config.h" 12 #include "build/build_config.h"
13 #include "components/resource_provider/public/cpp/resource_loader.h" 13 #include "components/resource_provider/public/cpp/resource_loader.h"
14 #include "mojo/shell/public/cpp/application_impl.h" 14 #include "mojo/shell/public/cpp/shell.h"
15 #include "ui/aura/env.h" 15 #include "ui/aura/env.h"
16 #include "ui/base/ime/input_method_initializer.h" 16 #include "ui/base/ime/input_method_initializer.h"
17 #include "ui/base/resource/resource_bundle.h" 17 #include "ui/base/resource/resource_bundle.h"
18 #include "ui/base/ui_base_paths.h" 18 #include "ui/base/ui_base_paths.h"
19 #include "ui/views/views_delegate.h" 19 #include "ui/views/views_delegate.h"
20 20
21 #if defined(OS_LINUX) && !defined(OS_ANDROID) 21 #if defined(OS_LINUX) && !defined(OS_ANDROID)
22 #include "components/font_service/public/cpp/font_loader.h" 22 #include "components/font_service/public/cpp/font_loader.h"
23 #endif 23 #endif
24 24
(...skipping 18 matching lines...) Expand all
43 #endif 43 #endif
44 void OnBeforeWidgetInit( 44 void OnBeforeWidgetInit(
45 Widget::InitParams* params, 45 Widget::InitParams* params,
46 internal::NativeWidgetDelegate* delegate) override {} 46 internal::NativeWidgetDelegate* delegate) override {}
47 47
48 DISALLOW_COPY_AND_ASSIGN(MusViewsDelegate); 48 DISALLOW_COPY_AND_ASSIGN(MusViewsDelegate);
49 }; 49 };
50 50
51 } // namespace 51 } // namespace
52 52
53 AuraInit::AuraInit(mojo::ApplicationImpl* app, const std::string& resource_file) 53 AuraInit::AuraInit(mojo::Shell* shell, const std::string& resource_file)
54 : resource_file_(resource_file), 54 : resource_file_(resource_file),
55 views_delegate_(new MusViewsDelegate) { 55 views_delegate_(new MusViewsDelegate) {
56 aura::Env::CreateInstance(false); 56 aura::Env::CreateInstance(false);
57 57
58 InitializeResources(app); 58 InitializeResources(shell);
59 59
60 ui::InitializeInputMethodForTesting(); 60 ui::InitializeInputMethodForTesting();
61 } 61 }
62 62
63 AuraInit::~AuraInit() { 63 AuraInit::~AuraInit() {
64 #if defined(OS_LINUX) && !defined(OS_ANDROID) 64 #if defined(OS_LINUX) && !defined(OS_ANDROID)
65 if (font_loader_.get()) { 65 if (font_loader_.get()) {
66 SkFontConfigInterface::SetGlobal(nullptr); 66 SkFontConfigInterface::SetGlobal(nullptr);
67 // FontLoader is ref counted. We need to explicitly shutdown the background 67 // FontLoader is ref counted. We need to explicitly shutdown the background
68 // thread, otherwise the background thread may be shutdown after the app is 68 // thread, otherwise the background thread may be shutdown after the app is
69 // torn down, when we're in a bad state. 69 // torn down, when we're in a bad state.
70 font_loader_->Shutdown(); 70 font_loader_->Shutdown();
71 } 71 }
72 #endif 72 #endif
73 } 73 }
74 74
75 void AuraInit::InitializeResources(mojo::ApplicationImpl* app) { 75 void AuraInit::InitializeResources(mojo::Shell* shell) {
76 if (ui::ResourceBundle::HasSharedInstance()) 76 if (ui::ResourceBundle::HasSharedInstance())
77 return; 77 return;
78 resource_provider::ResourceLoader resource_loader( 78 resource_provider::ResourceLoader resource_loader(
79 app, GetResourcePaths(resource_file_)); 79 shell, GetResourcePaths(resource_file_));
80 if (!resource_loader.BlockUntilLoaded()) 80 if (!resource_loader.BlockUntilLoaded())
81 return; 81 return;
82 CHECK(resource_loader.loaded()); 82 CHECK(resource_loader.loaded());
83 ui::RegisterPathProvider(); 83 ui::RegisterPathProvider();
84 base::File pak_file = resource_loader.ReleaseFile(resource_file_); 84 base::File pak_file = resource_loader.ReleaseFile(resource_file_);
85 base::File pak_file_2 = pak_file.Duplicate(); 85 base::File pak_file_2 = pak_file.Duplicate();
86 ui::ResourceBundle::InitSharedInstanceWithPakFileRegion( 86 ui::ResourceBundle::InitSharedInstanceWithPakFileRegion(
87 std::move(pak_file), base::MemoryMappedFile::Region::kWholeFile); 87 std::move(pak_file), base::MemoryMappedFile::Region::kWholeFile);
88 ui::ResourceBundle::GetSharedInstance().AddDataPackFromFile( 88 ui::ResourceBundle::GetSharedInstance().AddDataPackFromFile(
89 std::move(pak_file_2), ui::SCALE_FACTOR_100P); 89 std::move(pak_file_2), ui::SCALE_FACTOR_100P);
90 90
91 // Initialize the skia font code to go ask fontconfig underneath. 91 // Initialize the skia font code to go ask fontconfig underneath.
92 #if defined(OS_LINUX) && !defined(OS_ANDROID) 92 #if defined(OS_LINUX) && !defined(OS_ANDROID)
93 font_loader_ = skia::AdoptRef(new font_service::FontLoader(app->shell())); 93 font_loader_ = skia::AdoptRef(new font_service::FontLoader(shell));
94 SkFontConfigInterface::SetGlobal(font_loader_.get()); 94 SkFontConfigInterface::SetGlobal(font_loader_.get());
95 #endif 95 #endif
96 96
97 // There is a bunch of static state in gfx::Font, by running this now, 97 // There is a bunch of static state in gfx::Font, by running this now,
98 // before any other apps load, we ensure all the state is set up. 98 // before any other apps load, we ensure all the state is set up.
99 gfx::Font(); 99 gfx::Font();
100 } 100 }
101 101
102 } // namespace views 102 } // namespace views
OLDNEW
« no previous file with comments | « ui/views/mus/aura_init.h ('k') | ui/views/mus/native_widget_mus.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698