Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: mandoline/ui/omnibox/omnibox_application.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mandoline/ui/desktop_ui/browser_window.cc ('k') | mandoline/ui/omnibox/omnibox_application.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mandoline/ui/omnibox/omnibox_application.h
diff --git a/mandoline/ui/omnibox/omnibox_application.h b/mandoline/ui/omnibox/omnibox_application.h
index f44ae988ce42e0634f84b7201b893c3cc6342214..91df2a06483d38c7ce4c35cb427c4c642042b454 100644
--- a/mandoline/ui/omnibox/omnibox_application.h
+++ b/mandoline/ui/omnibox/omnibox_application.h
@@ -12,7 +12,7 @@
#include "mojo/shell/public/cpp/interface_factory.h"
namespace mojo {
-class ApplicationImpl;
+class Shell;
}
namespace mandoline {
@@ -25,7 +25,8 @@ class OmniboxApplication : public mojo::ApplicationDelegate,
private:
// Overridden from mojo::ApplicationDelegate:
- void Initialize(mojo::ApplicationImpl* app) override;
+ void Initialize(mojo::Shell* shell, const std::string& url,
+ uint32_t id) override;
bool AcceptConnection(
mojo::ApplicationConnection* connection) override;
@@ -33,7 +34,7 @@ class OmniboxApplication : public mojo::ApplicationDelegate,
void Create(mojo::ApplicationConnection* connection,
mojo::InterfaceRequest<Omnibox> request) override;
- mojo::ApplicationImpl* app_;
+ mojo::Shell* shell_;
mojo::TracingImpl tracing_;
DISALLOW_COPY_AND_ASSIGN(OmniboxApplication);
« no previous file with comments | « mandoline/ui/desktop_ui/browser_window.cc ('k') | mandoline/ui/omnibox/omnibox_application.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698