Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 1679573002: Move shell interfaces into the shell.mojom namespace. (Closed)

Created:
4 years, 10 months ago by Ben Goodger (Google)
Modified:
4 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, jochen+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, nasko+codewatch_chromium.org, penghuang+watch-mandoline_chromium.org, qsr+mojo_chromium.org, rjkroege, sadrul, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@delegate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move shell interfaces into the shell.mojom namespace. TBR=rockot@chromium.org R=palmer@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/9aaf303247f22bb0ad2a2eea88126e547e54d41f Cr-Commit-Position: refs/heads/master@{#374022}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+464 lines, -358 lines) Patch
M components/bitmap_uploader/bitmap_uploader.h View 2 chunks +5 lines, -1 line 0 comments Download
M components/bitmap_uploader/bitmap_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/font_service/public/cpp/font_loader.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M components/font_service/public/cpp/font_loader.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/content_handler_impl.h View 2 chunks +8 lines, -7 lines 0 comments Download
M components/html_viewer/content_handler_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/global_state.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/html_viewer/html_document_application_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_document_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/html_viewer.h View 2 chunks +6 lines, -4 lines 0 comments Download
M components/html_viewer/html_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/layout_test_content_handler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/layout_test_content_handler_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/layout_test_html_viewer.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/html_viewer/layout_test_html_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/media_factory.h View 4 chunks +7 lines, -3 lines 0 comments Download
M components/html_viewer/media_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/android_loader.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/mus/android_loader.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M components/pdf_viewer/pdf_viewer.cc View 4 chunks +13 lines, -10 lines 0 comments Download
M components/web_view/frame_connection.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/web_view/frame_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_mojo_shell.h View 2 chunks +8 lines, -6 lines 0 comments Download
M content/browser/frame_host/frame_mojo_shell.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_client_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M content/browser/mojo/renderer_capability_filter.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/child/process_control_impl.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/child/process_control_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/process_control.mojom View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.h View 2 chunks +10 lines, -8 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mash/example/window_type_launcher/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/non_client_frame_controller.h View 2 chunks +5 lines, -1 line 0 comments Download
M mash/wm/non_client_frame_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/root_window_controller.h View 2 chunks +5 lines, -1 line 0 comments Download
M mash/wm/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_instance.h View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/shell/application_instance.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/application_loader.h View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/shell/application_manager.h View 4 chunks +11 lines, -10 lines 0 comments Download
M mojo/shell/application_manager.cc View 9 chunks +21 lines, -19 lines 0 comments Download
M mojo/shell/application_manager_apptest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/application_manager_apptest_driver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/application_manager_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/shell/application_package_apptest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M mojo/shell/capability_filter_test.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/capability_filter_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/shell/connect_to_application_params.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/shell/fetcher/about_fetcher_unittest.cc View 4 chunks +10 lines, -9 lines 0 comments Download
M mojo/shell/native_runner.h View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/shell/package_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/package_manager/capability_filter_content_handler_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M mojo/shell/package_manager/content_handler_connection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/package_manager/content_handler_connection.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/shell/package_manager/content_handler_unittest.cc View 8 chunks +14 lines, -13 lines 0 comments Download
M mojo/shell/package_manager/package_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/package_manager/package_manager_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/application_impl.h View 7 chunks +24 lines, -16 lines 0 comments Download
M mojo/shell/public/cpp/content_handler_factory.h View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_impl.cc View 4 chunks +19 lines, -14 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_runner.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/lib/application_test_base.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M mojo/shell/public/cpp/lib/content_handler_factory.cc View 1 2 3 6 chunks +10 lines, -9 lines 0 comments Download
M mojo/shell/public/cpp/lib/service_registry.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/public/cpp/lib/service_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/interfaces/application.mojom View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/public/interfaces/application_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/interfaces/content_handler.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/public/interfaces/shell.mojom View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/shell/runner/child/child_controller.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/runner/child/runner_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/runner/child/runner_connection.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M mojo/shell/runner/child/test_native_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/runner/host/child_process.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/runner/host/child_process_host.h View 2 chunks +6 lines, -5 lines 0 comments Download
M mojo/shell/runner/host/child_process_host.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M mojo/shell/runner/host/in_process_native_runner.h View 1 chunk +5 lines, -4 lines 0 comments Download
M mojo/shell/runner/host/in_process_native_runner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/runner/host/native_application_support.h View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/shell/runner/host/native_application_support.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/shell/runner/host/out_of_process_native_runner.h View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/shell/runner/host/out_of_process_native_runner.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/shell_application_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell_application_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell_application_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/standalone/android/android_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/standalone/android/android_handler.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/shell/standalone/android/android_handler_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/standalone/android/android_handler_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/standalone/android/background_application_loader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/standalone/android/background_application_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/standalone/android/background_application_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/standalone/android/ui_application_loader_android.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/standalone/android/ui_application_loader_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/static_application_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/static_application_loader.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/shell/test_package_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/shell/test_package_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.h View 3 chunks +6 lines, -2 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/platform_window_mus.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/mus/platform_window_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/surface_binding.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/mus/surface_binding.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M ui/views/mus/surface_context_factory.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/mus/surface_context_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/window_tree_host_mus.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (15 generated)
Ben Goodger (Google)
4 years, 10 months ago (2016-02-06 00:09:51 UTC) #2
palmer
Rubberstamp LGTM
4 years, 10 months ago (2016-02-06 00:16:05 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 10 months ago (2016-02-06 00:48:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679573002/1
4 years, 10 months ago (2016-02-06 00:50:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/18443) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-06 01:12:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679573002/20001
4 years, 10 months ago (2016-02-06 04:17:39 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/18502)
4 years, 10 months ago (2016-02-06 04:47:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679573002/40001
4 years, 10 months ago (2016-02-06 05:22:44 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/18531)
4 years, 10 months ago (2016-02-06 06:06:53 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679573002/60001
4 years, 10 months ago (2016-02-06 06:15:56 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/177482)
4 years, 10 months ago (2016-02-06 06:51:35 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1679573002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1679573002/80001
4 years, 10 months ago (2016-02-06 07:14:13 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-06 08:56:59 UTC) #27
commit-bot: I haz the power
4 years, 10 months ago (2016-02-06 08:57:40 UTC) #29
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9aaf303247f22bb0ad2a2eea88126e547e54d41f
Cr-Commit-Position: refs/heads/master@{#374022}

Powered by Google App Engine
This is Rietveld 408576698