Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Unified Diff: mojo/services/test_service/test_request_tracker_application.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/test_service/test_request_tracker_application.h
diff --git a/mojo/services/test_service/test_request_tracker_application.h b/mojo/services/test_service/test_request_tracker_application.h
index 960f5155181e60869e9dad832a98c47439f90595..8d7f84c084888dcbc6bd4f41b48869dcc499e0c8 100644
--- a/mojo/services/test_service/test_request_tracker_application.h
+++ b/mojo/services/test_service/test_request_tracker_application.h
@@ -25,9 +25,8 @@ class TestRequestTrackerApplication
TestRequestTrackerApplication();
~TestRequestTrackerApplication() override;
- void Initialize(ApplicationImpl* app) override;
-
// ApplicationDelegate methods:
+ void Initialize(Shell* shell, const std::string& url, uint32_t id) override;
bool AcceptConnection(ApplicationConnection* connection) override;
// InterfaceFactory<TestTimeService> methods:
@@ -43,7 +42,7 @@ class TestRequestTrackerApplication
InterfaceRequest<TestTrackedRequestService> request) override;
private:
- ApplicationImpl* app_impl_;
+ Shell* shell_;
TrackingContext context_;
MOJO_DISALLOW_COPY_AND_ASSIGN(TestRequestTrackerApplication);
};
« no previous file with comments | « mojo/services/network/udp_socket_apptest.cc ('k') | mojo/services/test_service/test_request_tracker_application.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698