Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: components/filesystem/file_system_app.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/devtools_service/devtools_service_delegate.cc ('k') | components/filesystem/file_system_app.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/filesystem/file_system_app.h
diff --git a/components/filesystem/file_system_app.h b/components/filesystem/file_system_app.h
index 1eb1305e7f3ea990743a278fb5fea3bbd314e395..b8ef41c75ff0baac430f4ae339d22b6a2ce829ce 100644
--- a/components/filesystem/file_system_app.h
+++ b/components/filesystem/file_system_app.h
@@ -14,7 +14,7 @@
#include "mojo/shell/public/cpp/interface_factory.h"
namespace mojo {
-class ApplicationImpl;
+class Shell;
}
namespace filesystem {
@@ -35,7 +35,8 @@ class FileSystemApp : public mojo::ApplicationDelegate,
void OnDirectoryConnectionError(DirectoryImpl* directory);
// |ApplicationDelegate| override:
- void Initialize(mojo::ApplicationImpl* app) override;
+ void Initialize(mojo::Shell* shell, const std::string& url,
+ uint32_t id) override;
bool AcceptConnection(
mojo::ApplicationConnection* connection) override;
bool ShellConnectionLost() override;
@@ -59,7 +60,7 @@ class FileSystemApp : public mojo::ApplicationDelegate,
};
std::vector<Client> client_mapping_;
- mojo::ApplicationImpl* app_;
+ mojo::Shell* shell_;
mojo::TracingImpl tracing_;
// Set to true when our shell connection is closed. On connection error, we
« no previous file with comments | « components/devtools_service/devtools_service_delegate.cc ('k') | components/filesystem/file_system_app.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698