components/web_view/test_runner/test_runner_application_delegate.h - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_view/test_runner/test_runner_application_delegate.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_view/test_frame_tree_delegate.cc ('k') | components/web_view/test_runner/test_runner_application_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_view/test_runner/test_runner_application_delegate.h

diff --git a/components/web_view/test_runner/test_runner_application_delegate.h b/components/web_view/test_runner/test_runner_application_delegate.h

index dd0b33c3777d4b7900b056cc5627c95cfe653149..4fd2c80614bffa8cde2dbebe4b6860f81463067d 100644

--- a/components/web_view/test_runner/test_runner_application_delegate.h

+++ b/components/web_view/test_runner/test_runner_application_delegate.h

@@ -39,7 +39,8 @@ class TestRunnerApplicationDelegate

void Terminate();

// mojo::ApplicationDelegate:

- void Initialize(mojo::ApplicationImpl* app) override;

+ void Initialize(mojo::Shell* shell, const std::string& url,

+ uint32_t id) override;

bool AcceptConnection(

mojo::ApplicationConnection* connection) override;

@@ -67,7 +68,7 @@ class TestRunnerApplicationDelegate

void Create(mojo::ApplicationConnection* connection,

mojo::InterfaceRequest<LayoutTestRunner> request) override;

- mojo::ApplicationImpl* app_;

+ mojo::Shell* shell_;

mus::mojom::WindowTreeHostPtr host_;

mus::Window* root_;