Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1925)

Unified Diff: components/mus/ws/window_manager_client_apptest.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/mus/ws/display_manager_factory.h ('k') | components/mus/ws/window_tree_apptest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/mus/ws/window_manager_client_apptest.cc
diff --git a/components/mus/ws/window_manager_client_apptest.cc b/components/mus/ws/window_manager_client_apptest.cc
index df8fcdc37af4a1f3d16c157d3458c5cd115110c4..2312d7282f99d496d95f70bfabd91c819aa44bc4 100644
--- a/components/mus/ws/window_manager_client_apptest.cc
+++ b/components/mus/ws/window_manager_client_apptest.cc
@@ -17,7 +17,6 @@
#include "components/mus/public/cpp/window_tree_delegate.h"
#include "mojo/converters/geometry/geometry_type_converters.h"
#include "mojo/shell/public/cpp/application_connection.h"
-#include "mojo/shell/public/cpp/application_impl.h"
#include "mojo/shell/public/cpp/application_test_base.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/mojo/geometry/geometry_util.h"
@@ -278,7 +277,7 @@ class WindowServerTest : public WindowServerTestBase {
mus::mojom::WindowTreeClientPtr
ConnectToApplicationAndGetWindowServerClient() {
mus::mojom::WindowTreeClientPtr client;
- application_impl()->ConnectToService(application_impl()->url(), &client);
+ shell()->ConnectToService(shell_url(), &client);
return client;
}
@@ -1156,7 +1155,7 @@ TEST_F(WindowServerTest, EstablishConnectionViaFactory) {
EstablishConnectionViaFactoryDelegate delegate(window_manager());
set_window_manager_delegate(&delegate);
scoped_ptr<WindowTreeConnection> second_connection(
- WindowTreeConnection::Create(this, application_impl()));
+ WindowTreeConnection::Create(this, shell()));
Window* window_in_second_connection =
second_connection->NewTopLevelWindow(nullptr);
ASSERT_TRUE(window_in_second_connection);
« no previous file with comments | « components/mus/ws/display_manager_factory.h ('k') | components/mus/ws/window_tree_apptest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698