mandoline/services/core_services/core_services_application_delegate.h - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/services/core_services/core_services_application_delegate.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/devices_app/devices_apptest.cc ('k') | mandoline/services/core_services/core_services_application_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mandoline/services/core_services/core_services_application_delegate.h

diff --git a/mandoline/services/core_services/core_services_application_delegate.h b/mandoline/services/core_services/core_services_application_delegate.h

index 1c43659ddaa372c27111c479174c9a1ecb0b2485..b50b491c022963a6eaa7f6276f6bfea8a2f39288 100644

--- a/mandoline/services/core_services/core_services_application_delegate.h

+++ b/mandoline/services/core_services/core_services_application_delegate.h

@@ -33,7 +33,8 @@ class CoreServicesApplicationDelegate

private:

// Overridden from mojo::ApplicationDelegate:

- void Initialize(mojo::ApplicationImpl* app) override;

+ void Initialize(mojo::Shell* shell, const std::string& url,

+ uint32_t id) override;

bool AcceptConnection(

mojo::ApplicationConnection* connection) override;

void Quit() override;

« no previous file with comments | « device/devices_app/devices_apptest.cc ('k') | mandoline/services/core_services/core_services_application_delegate.cc » ('j') | no next file with comments »